Summary: | editors/vscode fails build in 2024Q2 branch | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | bas | ||||||||
Component: | Individual Port(s) | Assignee: | Hiroki Tagato <tagattie> | ||||||||
Status: | Closed FIXED | ||||||||||
Severity: | Affects Only Me | CC: | grahamperrin | ||||||||
Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(tagattie) |
||||||||
Version: | Latest | ||||||||||
Hardware: | Any | ||||||||||
OS: | Any | ||||||||||
Attachments: |
|
Created attachment 251048 [details]
Patch
The build error is due to the recent update of www/node18 on 2024Q2 branch.
Can you try with this patch to see how it goes?
Unfortunately, no. I applied the patch but build still fails. I attached another build log from the patched port's build process. Created attachment 251084 [details]
Build log from the patched port.
(In reply to bas from comment #2) Build of the kerberos node module is successful with the patch on my local machine. Can you make it sure that the patch is really applied? Indeed, I botched the patch myself. The build now works correctly and I have a functioning package. A commit in branch 2024Q2 references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=0872856aa5c8f91039122351a478b568818651ff commit 0872856aa5c8f91039122351a478b568818651ff Author: Hiroki Tagato <tagattie@FreeBSD.org> AuthorDate: 2024-05-31 09:14:15 +0000 Commit: Hiroki Tagato <tagattie@FreeBSD.org> CommitDate: 2024-05-31 09:23:02 +0000 editors/vscode: fix build with node 18.20.0 or later www/node18 on 2024Q2 branch has been updated to 18.20.2 and it causes an error while building the kerberos node module. This is a direct commit to 2024Q2 to fix the build error. PR: 279315 Reported by: bas@area536.com Tested by: bas@area536.com .../patch-remote_node__modules_kerberos_src_kerberos.h (new) | 10 ++++++++++ 1 file changed, 10 insertions(+) The patch has been committed to 2024Q2 branch. Thanks for reporting and testing. |
Created attachment 250975 [details] Build log from Poudriere The build fails, seems to be due to a missing Kerberos dependency. See attached build log.