Bug 279454
| Summary: | graphics/openimageio: sort out Makefile, remove unnecessary dependencies and pet portclippy | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Vladimir Druzenko <vvd> | ||||
| Component: | Individual Port(s) | Assignee: | Vladimir Druzenko <vvd> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Some People | CC: | FreeBSD | ||||
| Priority: | --- | Flags: | FreeBSD:
maintainer-feedback+
|
||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Comment on attachment 251140 [details]
v1
You should remove TBB from the OPTIONS_DEFAULT as tbb is x86 only, so turning it on by default will break all other platforms.
so if you undo the OPTIONS_DEFAULT line and add
OPTIONS_DEFAULT_amd64= TBB
that should be right
Actually it seems the support for other cpus has been improved over the last few years, so you should be OK as it is. (In reply to Shane from comment #1) Option VDB require TBB - build warning: > Not using OpenVDB -- disabled (because TBB was not found) A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=d6b1bdaf042ee04786083b137b9c441888eb1d0f commit d6b1bdaf042ee04786083b137b9c441888eb1d0f Author: Vladimir Druzenko <vvd@FreeBSD.org> AuthorDate: 2024-06-02 10:52:40 +0000 Commit: Vladimir Druzenko <vvd@FreeBSD.org> CommitDate: 2024-06-02 11:09:31 +0000 graphics/{,py-}openimageio: sort out Makefile, remove unnecessary dependencies and pet portclippy - Add VDB_IMPLIES=TBB: OpenVDB require TBB - build warning: "Not using OpenVDB -- disabled (because TBB was not found)" - Remove unused dependencies science/hdf5 and graphics/squish. - Move devel/libfmt and graphics/libjpeg-turbo to BUILD_DEPENDS and RUN_DEPENDS: check during configure stage and doesn't link this both. - Force use devel/libfmt and textproc/pugixml from ports and prevent use embedded copies. - Remove GL=glew from IMAGEVIEWER - it doesn't link with libGLEW. - Remove old and removed by upstream CMAKE options NOTHREADS, USE_OPENSSL, USE_OPENGL. - Sort options. PR: 279454 Approved by: Shane <FreeBSD@ShaneWare.Biz> (maintainer) graphics/openimageio/Makefile | 86 ++++++++++++++++++++-------------------- graphics/openimageio/pkg-plist | 6 --- graphics/py-openimageio/Makefile | 4 +- 3 files changed, 46 insertions(+), 50 deletions(-) |
Created attachment 251140 [details] v1 Tested build in poudriere (testport) and on live system 13.3 amd64. There are a lot of small changes - I can explain each.