Bug 279454 - graphics/openimageio: sort out Makefile, remove unnecessary dependencies and pet portclippy
Summary: graphics/openimageio: sort out Makefile, remove unnecessary dependencies and ...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Vladimir Druzenko
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-06-01 18:32 UTC by Vladimir Druzenko
Modified: 2024-06-02 11:18 UTC (History)
1 user (show)

See Also:
FreeBSD: maintainer-feedback+


Attachments
v1 (6.88 KB, patch)
2024-06-01 18:32 UTC, Vladimir Druzenko
vvd: maintainer-approval? (FreeBSD)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vladimir Druzenko freebsd_committer freebsd_triage 2024-06-01 18:32:39 UTC
Created attachment 251140 [details]
v1

Tested build in poudriere (testport) and on live system 13.3 amd64.
There are a lot of small changes - I can explain each.
Comment 1 Shane 2024-06-02 03:45:50 UTC
Comment on attachment 251140 [details]
v1

You should remove TBB from the OPTIONS_DEFAULT as tbb is x86 only, so turning it on by default will break all other platforms.

so if you undo the OPTIONS_DEFAULT line and add
OPTIONS_DEFAULT_amd64= TBB
that should be right
Comment 2 Shane 2024-06-02 03:55:12 UTC
Actually it seems the support for other cpus has been improved over the last few years, so you should be OK as it is.
Comment 3 Vladimir Druzenko freebsd_committer freebsd_triage 2024-06-02 10:52:02 UTC
(In reply to Shane from comment #1)
Option VDB require TBB - build warning:
> Not using OpenVDB -- disabled (because TBB was not found)
Comment 4 commit-hook freebsd_committer freebsd_triage 2024-06-02 11:17:09 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=d6b1bdaf042ee04786083b137b9c441888eb1d0f

commit d6b1bdaf042ee04786083b137b9c441888eb1d0f
Author:     Vladimir Druzenko <vvd@FreeBSD.org>
AuthorDate: 2024-06-02 10:52:40 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2024-06-02 11:09:31 +0000

    graphics/{,py-}openimageio: sort out Makefile, remove unnecessary dependencies and pet portclippy

    - Add VDB_IMPLIES=TBB: OpenVDB require TBB - build warning:
    "Not using OpenVDB -- disabled (because TBB was not found)"
    - Remove unused dependencies science/hdf5 and graphics/squish.
    - Move devel/libfmt and graphics/libjpeg-turbo to BUILD_DEPENDS and
    RUN_DEPENDS: check during configure stage and doesn't link this both.
    - Force use devel/libfmt and textproc/pugixml from ports and prevent
    use embedded copies.
    - Remove GL=glew from IMAGEVIEWER - it doesn't link with libGLEW.
    - Remove old and removed by upstream CMAKE options NOTHREADS,
    USE_OPENSSL, USE_OPENGL.
    - Sort options.

    PR:             279454
    Approved by:    Shane <FreeBSD@ShaneWare.Biz> (maintainer)

 graphics/openimageio/Makefile    | 86 ++++++++++++++++++++--------------------
 graphics/openimageio/pkg-plist   |  6 ---
 graphics/py-openimageio/Makefile |  4 +-
 3 files changed, 46 insertions(+), 50 deletions(-)