Bug 281586

Summary:

multimedia/droidcam: fix for system tray icon and add pkg-message

Product:

Ports & Packages

Reporter:

Yusuf Yaman <nxjoseph>

Component:

Individual Port(s)

Assignee:

Robert Clausecker <fuz>

Status:

Closed FIXED

Severity:

Affects Only Me

CC:

fuz, nxjoseph

Priority:

---

Version:

Latest

Hardware:

Any

OS:

Any

Attachments:

Description	Flags
multimedia/droidcam	nxjoseph: maintainer-approval+
how system tray icon look before the fix	none
how system tray icon look after the fix	none
pkg-message	none

Description Yusuf Yaman 2024-09-19 10:34:19 UTC

Comment 1 Yusuf Yaman 2024-09-19 10:35:37 UTC

Created attachment 253659 [details]
multimedia/droidcam

Port changes:
 * Fix for system tray icon doesn't show up
 * Change GitHub project name

Comment 2 Yusuf Yaman 2024-09-19 10:37:19 UTC

Created attachment 253660 [details]
how system tray icon look before the fix

Comment 3 Yusuf Yaman 2024-09-19 10:37:36 UTC

Created attachment 253661 [details]
how system tray icon look after the fix

Comment 4 Yusuf Yaman 2024-09-19 13:17:55 UTC

Created attachment 253663 [details]
pkg-message

I wanted to add a pkg-message too.

Comment 5 Robert Clausecker freebsd_committer

2024-09-20 15:27:43 UTC

Your patch fixes the issue, but is not PREFIX aware.  On commit, I'll replace it with something that works even if PREFIX is changed.

Comment 6 Yusuf Yaman 2024-09-20 15:32:20 UTC

(In reply to Robert Clausecker from comment #5)
Oh, sorry, I didn't think about %%PREFIX%%. 

I'm looking forward for commit and will check the change to learn about it.

Would it be correct to add %%PREFIX%% to the .desktop file too?

Comment 7 Robert Clausecker freebsd_committer

2024-09-20 15:35:19 UTC

> Would it be correct to add %%PREFIX%% to the .desktop file too?

Yes, indeed.  In fact, that's part of the edit I have prepared.

Comment 8 Yusuf Yaman 2024-09-20 15:36:32 UTC

(In reply to Robert Clausecker from comment #7)
Okay, thanks. I will try these changes myself too.

Comment 9 Yusuf Yaman 2024-09-20 15:50:45 UTC

If you haven't committed already, can you add this missing library dependency too?

```
Error: /usr/local/bin/droidcam is linked to /usr/local/lib/libwayland-client.so.0 from graphics/wayland but it is not declared as a dependency
Warning: you need LIB_DEPENDS+=libwayland-client.so:graphics/wayland
```

Comment 10 Robert Clausecker freebsd_committer

2024-09-21 10:13:13 UTC

Sure thing.

The commit is planned for next week, once I'm done with extra testing.

Comment 11 Yusuf Yaman 2024-09-21 10:14:29 UTC

(In reply to Robert Clausecker from comment #10)
Okay, thanks. Have a good one.

Comment 12 commit-hook freebsd_committer

2024-09-25 06:31:16 UTC

A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=adc8361b87972451ffbfe619aa714bc2fd2fa024

commit adc8361b87972451ffbfe619aa714bc2fd2fa024
Author:     Yusuf Yaman <nxjoseph@protonmail.com>
AuthorDate: 2024-09-19 10:31:49 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2024-09-25 06:28:05 +0000

    multimedia/droidcam: fix system tray icon not showing up

     * Fix system tray icon not showing up
     * Change GitHub project name
     * add pkg-message

    PR:             281586
    Event:          EuroBSDcon 2024

 multimedia/droidcam/Makefile                            | 10 ++++++++--
 multimedia/droidcam/distinfo                            |  6 +++---
 multimedia/droidcam/files/patch-droidcam.desktop (gone) | 11 -----------
 multimedia/droidcam/pkg-message (new)                   | 14 ++++++++++++++
 4 files changed, 25 insertions(+), 16 deletions(-)

Comment 13 Robert Clausecker freebsd_committer

2024-09-25 06:35:12 UTC

Thank you for your contribution.

Comment 14 Yusuf Yaman 2024-09-25 21:39:52 UTC

You are welcome and thanks for more than giving a look. I noticed that you didn't include "share" directory in program's icon path, no worries, i just opened a bug report 281720 for it and made minor changes.