Bug 281586 - multimedia/droidcam: fix for system tray icon and add pkg-message
Summary: multimedia/droidcam: fix for system tray icon and add pkg-message
Status: In Progress
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Robert Clausecker
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-09-19 10:34 UTC by Yusuf Yaman
Modified: 2024-09-20 15:50 UTC (History)
2 users (show)

See Also:


Attachments
multimedia/droidcam (2.69 KB, patch)
2024-09-19 10:35 UTC, Yusuf Yaman
nxjoseph: maintainer-approval+
Details | Diff
how system tray icon look before the fix (2.53 KB, image/png)
2024-09-19 10:37 UTC, Yusuf Yaman
no flags Details
how system tray icon look after the fix (2.85 KB, image/png)
2024-09-19 10:37 UTC, Yusuf Yaman
no flags Details
pkg-message (459 bytes, text/plain)
2024-09-19 13:17 UTC, Yusuf Yaman
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuf Yaman 2024-09-19 10:34:19 UTC

    
Comment 1 Yusuf Yaman 2024-09-19 10:35:37 UTC
Created attachment 253659 [details]
multimedia/droidcam

Port changes:
 * Fix for system tray icon doesn't show up
 * Change GitHub project name
Comment 2 Yusuf Yaman 2024-09-19 10:37:19 UTC
Created attachment 253660 [details]
how system tray icon look before the fix
Comment 3 Yusuf Yaman 2024-09-19 10:37:36 UTC
Created attachment 253661 [details]
how system tray icon look after the fix
Comment 4 Yusuf Yaman 2024-09-19 13:17:55 UTC
Created attachment 253663 [details]
pkg-message

I wanted to add a pkg-message too.
Comment 5 Robert Clausecker freebsd_committer freebsd_triage 2024-09-20 15:27:43 UTC
Your patch fixes the issue, but is not PREFIX aware.  On commit, I'll replace it with something that works even if PREFIX is changed.
Comment 6 Yusuf Yaman 2024-09-20 15:32:20 UTC
(In reply to Robert Clausecker from comment #5)
Oh, sorry, I didn't think about %%PREFIX%%. 

I'm looking forward for commit and will check the change to learn about it.

Would it be correct to add %%PREFIX%% to the .desktop file too?
Comment 7 Robert Clausecker freebsd_committer freebsd_triage 2024-09-20 15:35:19 UTC
> Would it be correct to add %%PREFIX%% to the .desktop file too?

Yes, indeed.  In fact, that's part of the edit I have prepared.
Comment 8 Yusuf Yaman 2024-09-20 15:36:32 UTC
(In reply to Robert Clausecker from comment #7)
Okay, thanks. I will try these changes myself too.
Comment 9 Yusuf Yaman 2024-09-20 15:50:45 UTC
If you haven't committed already, can you add this missing library dependency too?

```
Error: /usr/local/bin/droidcam is linked to /usr/local/lib/libwayland-client.so.0 from graphics/wayland but it is not declared as a dependency
Warning: you need LIB_DEPENDS+=libwayland-client.so:graphics/wayland
```