Bug 281720

Created attachment 253825 [details]
multimedia/droidcam

This patch fixes 281586 by adding forgotten directory pointing to the program's icon path.
Also, now it uses ${PORTNAME} wherever it's possible and also replaces program's
installation path with ${PREFIX} in program's .desktop file.

Comment 2 Robert Clausecker 2024-09-25 22:38:41 UTC

There's not really a need to use ${PORTNAME} all over the place.  Rule of thumb: only use ${PORTNAME} where the port would still work if you were to change PORTNAME to something else.  Strings that are just incidentally the same as PORTNAME but wouldn't change if you changed the port name should not use the macro.

But anyway, thanks for catching my oversight in bug #281586.  I had too many patches and didn't test enough.

(In reply to Robert Clausecker from comment #2)
Okay, i decided to not use any macro in this because i didn't understand it much.

You are welcome.

Created attachment 253833 [details]
multimedia/droidcam

Comment 5 Robert Clausecker 2024-09-26 18:13:01 UTC

At the end of the day, you can use PORTNAME however you want.  It's just a recommendation to use it the way I indicated.  Which way do you prefer?

(In reply to Robert Clausecker from comment #5)
Sorry for the delay.

Okay then, i'd like to use PORTNAME macro here. I meanwhile noticed that my REINPLACE_CMD macro didn't work properly because it was missing the whole old string and fixed them too.

Thanks.

Created attachment 253895 [details]
multimedia/droidcam

Created attachment 253896 [details]
multimedia/droidcam

I ran portfmt and fixed some order this time.

Comment 9 Robert Clausecker 2024-09-29 21:53:50 UTC

Once again sorry for my oversight.

I have a bunch of ports left to test and will commit your most recent patch once I'm done testing (should be soon-ish).

No problem. Okay, very thanks.

Comment 11 commit-hook 2024-09-30 14:09:10 UTC

A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=3377cfa4c2e7ab8a4b29fb977588de6e9b72b22c

commit 3377cfa4c2e7ab8a4b29fb977588de6e9b72b22c
Author:     Yusuf Yaman <nxjoseph@protonmail.com>
AuthorDate: 2024-09-29 21:09:12 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2024-09-30 14:07:48 +0000

    multimedia/droidcam: Fix previous patch and minor changes

    This patch fixes 281586 by adding forgotten directory pointing to the program's icon path.
    Also, now it uses ${PORTNAME} wherever it's possible and replaces program's
    installation path with ${PREFIX} in program's .desktop file.

    PR:             281720
    Fixes:          adc8361b87972451ffbfe619aa714bc2fd2fa024

 multimedia/droidcam/Makefile | 30 +++++++++++++++++-------------
 1 file changed, 17 insertions(+), 13 deletions(-)

Comment 12 Robert Clausecker 2024-09-30 14:12:47 UTC

Thank you for your contribution.

You are welcome and thanks for giving a look. Have a good one.