Bug 282371

Summary: editors/vscode: Fix build with clang 19
Product: Ports & Packages Reporter: Guido Falsi <madpilot>
Component: Individual Port(s)Assignee: Hiroki Tagato <tagattie>
Status: Closed FIXED    
Severity: Affects Only Me Flags: tagattie: maintainer-feedback+
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Bug Depends on: 282370    
Bug Blocks:    
Attachments:
Description Flags
patch none

Description Guido Falsi freebsd_committer freebsd_triage 2024-10-27 22:06:53 UTC 
Created attachment 254583 [details]
patch

Hi,

After upgrading to recent head I noticed vscode failing to build, due to the clang 19 upgrade.

I've created a patch that works for me, based on an upstream commit [1]

Hope this can be useful


[1] https://github.com/tree-sitter/node-tree-sitter/commit/a90b361cb5ac45e8e2f6f6e7fd56d0892de30cc7
Comment 1 commit-hook freebsd_committer freebsd_triage 2024-11-03 23:11:27 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a811f5edccef485b6ada224cacb3a3b07dcd18d3

commit a811f5edccef485b6ada224cacb3a3b07dcd18d3
Author:     Guido Falsi <madpilot@FreeBSD.org>
AuthorDate: 2024-11-03 23:09:08 +0000
Commit:     Hiroki Tagato <tagattie@FreeBSD.org>
CommitDate: 2024-11-03 23:10:55 +0000

    editors/vscode: fix build with clang 19

    PR:             282371
    Reported by:    madpilot
    MFH:            2024Q4

 ...atch-build_node__modules_tree-sitter_src_node.cc (new) | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-11-03 23:12:28 UTC 
A commit in branch 2024Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=895bbbe0832cdda00fea9d50b6c6ac6251842add

commit 895bbbe0832cdda00fea9d50b6c6ac6251842add
Author:     Guido Falsi <madpilot@FreeBSD.org>
AuthorDate: 2024-11-03 23:09:08 +0000
Commit:     Hiroki Tagato <tagattie@FreeBSD.org>
CommitDate: 2024-11-03 23:12:02 +0000

    editors/vscode: fix build with clang 19

    PR:             282371
    Reported by:    madpilot
    MFH:            2024Q4

    (cherry picked from commit a811f5edccef485b6ada224cacb3a3b07dcd18d3)

 ...atch-build_node__modules_tree-sitter_src_node.cc (new) | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
Comment 3 Hiroki Tagato freebsd_committer freebsd_triage 2024-11-03 23:15:03 UTC 
Hi Guido,

I have confirmed the patch fixes the build issue with clang 19.

Changes committed. Thanks for the patch!