Bug 282370 - devel/electron30: Fix build with clang 19
Summary: devel/electron30: Fix build with clang 19
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Hiroki Tagato
URL:
Keywords:
Depends on:
Blocks: 282371
  Show dependency tree / graph
 
Reported: 2024-10-27 21:53 UTC by Guido Falsi
Modified: 2024-11-01 20:52 UTC (History)
0 users

See Also:
tagattie: maintainer-feedback+

Attachments
patch (8.69 KB, patch)
2024-10-27 21:53 UTC, Guido Falsi 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Hiroki Tagato freebsd_committer freebsd_triage 2024-10-31 10:45:43 UTC 
(In reply to Guido Falsi from comment #0)

Hi Guido,

Thank you for the patch.

I have confirmed that the patched port successfully builds with clang 19. I will commit the changes shortly.
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-10-31 10:57:54 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=85e785bd0f4e3e3b979448594b986ee7174acc4a

commit 85e785bd0f4e3e3b979448594b986ee7174acc4a
Author:     Guido Falsi <madpilot@FreeBSD.org>
AuthorDate: 2024-10-31 10:53:13 +0000
Commit:     Hiroki Tagato <tagattie@FreeBSD.org>
CommitDate: 2024-10-31 10:57:00 +0000

    devel/electron30: fix build with clang 19

    PR:             282370
    Reported by:    madpilot
    MFH:            2024Q4

 ...c_partition__alloc__base_no__destructor.h (new) | 13 ++++++
 .../files/patch-base_containers_id__map.h (new)    | 13 ++++++
 ...h-electron_shell_common_keyboard__util.cc (new) | 11 +++++
 ..._quiche_quic_core_quic__interval__deque.h (new) | 17 +++++++
 ...blink_renderer_platform_wtf_hash__table.h (new) | 31 +++++++++++++
 ...ing_internal_track__event__data__source.h (new) | 54 ++++++++++++++++++++++
 6 files changed, 139 insertions(+)
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-10-31 10:58:55 UTC 
A commit in branch 2024Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=5d2dc5802e1e837ee531c8301b790229159fefa2

commit 5d2dc5802e1e837ee531c8301b790229159fefa2
Author:     Guido Falsi <madpilot@FreeBSD.org>
AuthorDate: 2024-10-31 10:53:13 +0000
Commit:     Hiroki Tagato <tagattie@FreeBSD.org>
CommitDate: 2024-10-31 10:58:12 +0000

    devel/electron30: fix build with clang 19

    PR:             282370
    Reported by:    madpilot
    MFH:            2024Q4

    (cherry picked from commit 85e785bd0f4e3e3b979448594b986ee7174acc4a)

 ...c_partition__alloc__base_no__destructor.h (new) | 13 ++++++
 .../files/patch-base_containers_id__map.h (new)    | 13 ++++++
 ...h-electron_shell_common_keyboard__util.cc (new) | 11 +++++
 ..._quiche_quic_core_quic__interval__deque.h (new) | 17 +++++++
 ...blink_renderer_platform_wtf_hash__table.h (new) | 31 +++++++++++++
 ...ing_internal_track__event__data__source.h (new) | 54 ++++++++++++++++++++++
 6 files changed, 139 insertions(+)
Comment 4 Hiroki Tagato freebsd_committer freebsd_triage 2024-10-31 11:08:21 UTC 
Committed, thanks!
Comment 5 commit-hook freebsd_committer freebsd_triage 2024-11-01 20:51:56 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=2457237c15a3db2b496a1e5660e9f0d4a6d56e64

commit 2457237c15a3db2b496a1e5660e9f0d4a6d56e64
Author:     Guido Falsi <madpilot@FreeBSD.org>
AuthorDate: 2024-11-01 20:50:10 +0000
Commit:     Hiroki Tagato <tagattie@FreeBSD.org>
CommitDate: 2024-11-01 20:51:19 +0000

    devel/electron31: fix build with clang 19

    PR:             282370
    Reported by:    madpilot
    MFH:            2024Q4

 ...h-electron_shell_common_keyboard__util.cc (new) | 11 +++++
 ...blink_renderer_platform_wtf_hash__table.h (new) | 31 +++++++++++++
 ...ing_internal_track__event__data__source.h (new) | 54 ++++++++++++++++++++++
 3 files changed, 96 insertions(+)
Comment 6 commit-hook freebsd_committer freebsd_triage 2024-11-01 20:52:57 UTC 
A commit in branch 2024Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=cf43f81e2d25d27dc7f3e0f7fc54ed9f4c68350f

commit cf43f81e2d25d27dc7f3e0f7fc54ed9f4c68350f
Author:     Guido Falsi <madpilot@FreeBSD.org>
AuthorDate: 2024-11-01 20:50:10 +0000
Commit:     Hiroki Tagato <tagattie@FreeBSD.org>
CommitDate: 2024-11-01 20:52:17 +0000

    devel/electron31: fix build with clang 19

    PR:             282370
    Reported by:    madpilot
    MFH:            2024Q4

    (cherry picked from commit 2457237c15a3db2b496a1e5660e9f0d4a6d56e64)

 ...h-electron_shell_common_keyboard__util.cc (new) | 11 +++++
 ...blink_renderer_platform_wtf_hash__table.h (new) | 31 +++++++++++++
 ...ing_internal_track__event__data__source.h (new) | 54 ++++++++++++++++++++++
 3 files changed, 96 insertions(+)