Bug 461

Summary: Bogus lseek warning when dump large filesystems
Product: Base System Reporter: mark tinguely <tinguely>
Component: binAssignee: freebsd-bugs (Nobody) <bugs>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Unspecified   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description mark tinguely 1995-05-30 08:00:02 UTC 
	When using dump/rdump on large filesytems (my case 3 GB), the lseek
	claims multiple times to have failed. The problem is a off_t is
	converted into a int and checked for a negative. A true lseek check
	should be checking if the off_t is equal to -1 for failure.

Fix: since the lseek is set from the beginning of the filesystem, I simple
	check if the lseek returned the offset that was requested. maybe a
	more efficent test would be a test for -1.

	I never got the "lseek2" error message, but I changed that as well
	just in case.
How-To-Repeat: 
	run dump on a large (> 2GB) filesystem
Comment 1 Joerg Wunsch freebsd_committer freebsd_triage 1995-06-24 18:16:51 UTC 
State Changed
From-To: open->closed


Suggested fix applied in version  1.3 of dump/traverse.c