Bug 461 - Bogus lseek warning when dump large filesystems
Summary: Bogus lseek warning when dump large filesystems
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: Unspecified
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 1995-05-30 08:00 UTC by mark tinguely
Modified: 1995-05-30 08:00 UTC (History)
0 users

See Also:

Attachments
file.diff (1.15 KB, patch)
1995-05-30 08:00 UTC, mark tinguely 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mark tinguely 1995-05-30 08:00:02 UTC 
	When using dump/rdump on large filesytems (my case 3 GB), the lseek
	claims multiple times to have failed. The problem is a off_t is
	converted into a int and checked for a negative. A true lseek check
	should be checking if the off_t is equal to -1 for failure.

Fix: since the lseek is set from the beginning of the filesystem, I simple
	check if the lseek returned the offset that was requested. maybe a
	more efficent test would be a test for -1.

	I never got the "lseek2" error message, but I changed that as well
	just in case.
How-To-Repeat: 
	run dump on a large (> 2GB) filesystem
Comment 1 Joerg Wunsch freebsd_committer freebsd_triage 1995-06-24 18:16:51 UTC 
State Changed
From-To: open->closed


Suggested fix applied in version  1.3 of dump/traverse.c