Bug 71665

Summary:

[patch] cleanup of the usr.sbin/dconschat code

Product:

Base System

Reporter:

Dan Lukes <dan>

Component:

bin

Assignee:

freebsd-bugs (Nobody) <bugs>

Status:

Closed Feedback Timeout

Severity:

Affects Only Me

CC:

ngie

Priority:

Normal

Keywords:

patch

Version:

5.3-BETA3

Hardware:

Any

OS:

Any

Attachments:

Description	Flags
file.diff	none

Description Dan Lukes 2004-09-12 18:40:25 UTC

	There are more than 5000 warnings issued during "make buildworld".
Some of them are false positives, but some of them are sign of true errors.

	Nobody is upset by warnings due it's amount, so some errors remain
uncorrected.

	I want to cleanup the code-base from warnings, so warnings will
become "attention mark" again.

usr.sbin/dconschat/dconschat.c:172: warning: dereferencing type-punned pointer will break strict-aliasing rules

How-To-Repeat: 	N/A

Comment 1 Enji Cooper freebsd_committer

2015-11-10 12:08:27 UTC

-fno-strict-aliasing is not usually a good thing to use. I'll see if I can fix it differently.

Comment 2 Enji Cooper freebsd_committer

2017-11-05 21:04:16 UTC

I have no way to test this. Untaking.

Comment 3 Graham Perrin freebsd_committer

2022-10-17 12:38:47 UTC

Keyword: 

    patch
or  patch-ready

– in lieu of summary line prefix: 

    [patch]

* bulk change for the keyword
* summary lines may be edited manually (not in bulk). 

Keyword descriptions and search interface: 

    <https://bugs.freebsd.org/bugzilla/describekeywords.cgi>

Comment 4 commit-hook freebsd_committer

2024-11-03 20:21:02 UTC

A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=75d11bfbc6d4289e4b3d91414e46a3af51f4402a

commit 75d11bfbc6d4289e4b3d91414e46a3af51f4402a
Author:     Ed Maste <emaste@FreeBSD.org>
AuthorDate: 2024-11-03 20:04:08 +0000
Commit:     Ed Maste <emaste@FreeBSD.org>
CommitDate: 2024-11-03 20:18:39 +0000

    dconschat: Increase WARNS to 2

    Follow the existing pattern of fflush() in verbose mode.

    PR:             71665
    Sponsored by:   The FreeBSD Foundation

 usr.sbin/dconschat/Makefile    | 2 +-
 usr.sbin/dconschat/dconschat.c | 6 ++++--
 2 files changed, 5 insertions(+), 3 deletions(-)

Comment 5 commit-hook freebsd_committer

2024-11-25 21:35:10 UTC

A commit in branch stable/14 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=e59630a3ddc0683df664459c59d633b881bd4b1d

commit e59630a3ddc0683df664459c59d633b881bd4b1d
Author:     Ed Maste <emaste@FreeBSD.org>
AuthorDate: 2024-11-03 20:04:08 +0000
Commit:     Ed Maste <emaste@FreeBSD.org>
CommitDate: 2024-11-25 21:33:46 +0000

    dconschat: Increase WARNS to 2

    Follow the existing pattern of fflush() in verbose mode.

    PR:             71665
    Sponsored by:   The FreeBSD Foundation

    (cherry picked from commit 75d11bfbc6d4289e4b3d91414e46a3af51f4402a)

 usr.sbin/dconschat/Makefile    | 2 +-
 usr.sbin/dconschat/dconschat.c | 6 ++++--
 2 files changed, 5 insertions(+), 3 deletions(-)