Bug 253323 - [patch] www/tinyproxy should remove $pidfile
Summary: [patch] www/tinyproxy should remove $pidfile
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Po-Chuan Hsieh
URL:
Keywords: buildisok, patch
Depends on:
Blocks:
 
Reported: 2021-02-07 17:21 UTC by Helge Oldach
Modified: 2024-05-28 10:26 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (sunpoet)

Attachments
Patch (353 bytes, patch)
2021-02-07 17:21 UTC, Helge Oldach 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Helge Oldach 2021-02-07 17:21:23 UTC 
Created attachment 222243 [details]
Patch

Since the PidFile is created as root and the daemon drops privileges, it cannot remove the PidFile upon exit:

Feb  7 17:27:11 nuc tinyproxy[49788]: Could not remove PID file "/var/run/tinyproxy.pid": Permission denied.

Therefore, have the service script clean up the stale PidFile.
Comment 1 Automation User 2021-02-22 01:34:58 UTC 
Build and package info is available at https://gitlab.com/swills/freebsd-ports/pipelines/259557446
Comment 2 Graham Perrin freebsd_committer freebsd_triage 2022-10-17 12:36:40 UTC 
Keyword: 

    patch
or  patch-ready

– in lieu of summary line prefix: 

    [patch]

* bulk change for the keyword
* summary lines may be edited manually (not in bulk). 

Keyword descriptions and search interface: 

    <https://bugs.freebsd.org/bugzilla/describekeywords.cgi>
Comment 3 Herbert J. Skuhra 2024-05-14 09:19:35 UTC 
maintainer timeout?
Comment 4 commit-hook freebsd_committer freebsd_triage 2024-05-28 10:25:11 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=f4fd84d27e6311cc52508e9c01a572d3dea05093

commit f4fd84d27e6311cc52508e9c01a572d3dea05093
Author:     Helge Oldach <freebsd@oldach.net>
AuthorDate: 2024-05-28 10:17:02 +0000
Commit:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
CommitDate: 2024-05-28 10:21:55 +0000

    www/tinyproxy: Remove pid file using service script

    - Bump PORTREVISION for package change

    PR:             253323

 www/tinyproxy/Makefile           | 1 +
 www/tinyproxy/files/tinyproxy.in | 2 ++
 2 files changed, 3 insertions(+)
Comment 5 Po-Chuan Hsieh freebsd_committer freebsd_triage 2024-05-28 10:26:31 UTC 
Committed. Thanks!