Bug 127121

Summary: [pf] [patch] pf incorrect log priority
Product: Base System Reporter: Jeff Wheelhouse <jdw>
Component: kernAssignee: freebsd-bugs (Nobody) <bugs>
Status: Open ---    
Severity: Affects Only Me Keywords: patch
Priority: Normal    
Version: 6.4-PRERELEASE   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description Jeff Wheelhouse 2008-09-05 22:20:05 UTC 
If round-robin load balancing is enabled, pf logs a message indicating
which address was chosen for each new state that is created.  This
produces a prodigious amount of information on a busy server, which can
render the server unusable, but the message is logged at priority
PF_DEBUG_MISC.

PF_DEBUG_MISC is identified as for "various errors."  Selecting a
destination address is ordinary operation, not an error.

Therefore I believe the appropriate log level for this message is
PF_DEBUG_NOISY.

Fix: Change PF_DEBUG_MISC to PF_DEBUG_NOISY at line 2407 of pf.c in this revision:

/*      $FreeBSD: src/sys/contrib/pf/net/pf.c,v 1.34.2.8 2007/11/21 13:52:04 dha
rtmei Exp $     */
/*      $OpenBSD: pf.c,v 1.502.2.1 2006/05/02 22:55:52 brad Exp $ */

(Patch enclosed.)

Patch attached with submission follows:
How-To-Repeat: 1. Run "pfctl -x misc" on a busy machine that uses round-robin load balancing. 
2. Cringe.
Comment 1 Remko Lodder freebsd_committer freebsd_triage 2008-09-05 23:35:05 UTC 
Responsible Changed
From-To: freebsd-bugs->freebsd-pf

reassign to pf team
Comment 2 Eitan Adler freebsd_committer freebsd_triage 2017-12-31 07:58:24 UTC 
For bugs matching the following criteria:

Status: In Progress Changed: (is less than) 2014-06-01

Reset to default assignee and clear in-progress tags.

Mail being skipped
Comment 3 Graham Perrin freebsd_committer freebsd_triage 2022-10-17 12:33:54 UTC 
Keyword: 

    patch
or  patch-ready

– in lieu of summary line prefix: 

    [patch]

* bulk change for the keyword
* summary lines may be edited manually (not in bulk). 

Keyword descriptions and search interface: 

    <https://bugs.freebsd.org/bugzilla/describekeywords.cgi>