Bug 235834

Summary: net/mosquitto: OpenSSL build fix broke mosquitto_passwd
Product: Ports & Packages Reporter: Ari Suutari <ari>
Component: Individual Port(s)Assignee: freebsd-ports-bugs (Nobody) <ports-bugs>
Status: Closed FIXED    
Severity: Affects Some People CC: brd, joe, swills
Priority: --- Keywords: regression
Version: LatestFlags: joe: maintainer-feedback+
koobs: merge-quarterly?
Hardware: Any   
OS: Any   
See Also: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=232168
https://github.com/eclipse/mosquitto/issues/1032
Attachments:
Description Flags
Fixed mosquitto_internal.h patch which defines HAVE_OPENSSL_OPAQUE_STRUCTS
none
Fixed mosquitto_passwd.c patch with correct #ifndef.
none
new patch for mosquitto_passwd.c none

Description Ari Suutari 2019-02-18 11:28:59 UTC 
Created attachment 202125 [details]
Fixed mosquitto_internal.h patch which defines HAVE_OPENSSL_OPAQUE_STRUCTS

OpenSSL fixes from bug #232168 break mosquitto_passwd. The problem was originally 
mentioned here:

https://github.com/eclipse/mosquitto/issues/1032

The patches reference HAVE_OPENSSL_OPAQUE_STRUCTS, but that is not defined anywhere. Also, #ifdef in mosquitto_passwd.c patch should be #ifndef.
Comment 1 Ari Suutari 2019-02-18 11:29:38 UTC 
Created attachment 202126 [details]
Fixed mosquitto_passwd.c patch with correct #ifndef.
Comment 2 Ari Suutari 2019-02-18 13:25:55 UTC 
Created attachment 202127 [details]
new patch for mosquitto_passwd.c

Fix was actually simpler. No need to modify patch-lib_mosquitto__internal.h.
Comment 3 joe 2019-03-11 01:19:06 UTC 
PS: The utility is broken on 11.2-RELEASE.

See the updated version here:

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236459