Summary: | Manpage pcap-filter(7) missing | ||||||
---|---|---|---|---|---|---|---|
Product: | Documentation | Reporter: | Martin Beran <martin> | ||||
Component: | Manual Pages | Assignee: | Hans Petter Selasky <hselasky> | ||||
Status: | Closed FIXED | ||||||
Severity: | Affects Some People | CC: | andrew, bugs, doc, emaste, hselasky, jamie, kevans, markj, phk | ||||
Priority: | --- | Keywords: | needs-qa, patch-ready, regression | ||||
Version: | Latest | ||||||
Hardware: | Any | ||||||
OS: | Any | ||||||
See Also: | https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=237631 | ||||||
Attachments: |
|
Description
Martin Beran
2019-05-14 11:44:14 UTC
It was this commit that stopped it being installed I think: https://github.com/freebsd/freebsd/commit/30f165e2d74c681f9df978d1f8f6eeef4569babb#diff-f47145dbca3572dd06e3bab12d4f176b There are a few other pages that don't get installed. It's trivial to add them back - but I don't know if they were removed for a reason? I attach a patch that adds in the man pages the libpcap distribution appears to install but the base system Makefile doesn't. They all seem of interest to libpcap users to me. I have also expanded the sed line to expand more macros found in the man pages. Created attachment 204657 [details]
/usr/src/lib/libpcap/Makefile
I can confirm this is also missing on 13.0-current r355131 installed from sources Assign to committer of r334277; patch looks good to me. I'll have a look at this on Monday. Patch basically looks OK. --HPS (In reply to Hans Petter Selasky from comment #5) Thanks, Hans! A commit references this bug: Author: hselasky Date: Mon Dec 16 09:11:39 UTC 2019 New revision: 355800 URL: https://svnweb.freebsd.org/changeset/base/355800 Log: Install missing pcap(3) manual pages and add missing manpage section substitutions. Submitted by: Martin Beran <martin@mber.cz> PR: 237893 MFC after: 1 week Sponsored by: Mellanox Technologies Changes: head/lib/libpcap/Makefile A commit references this bug: Author: hselasky Date: Wed Dec 25 09:28:07 UTC 2019 New revision: 356070 URL: https://svnweb.freebsd.org/changeset/base/356070 Log: MFC r355800: Install missing pcap(3) manual pages and add missing manpage section substitutions. Submitted by: Martin Beran <martin@mber.cz> PR: 237893 Sponsored by: Mellanox Technologies Changes: _U stable/12/ stable/12/lib/libpcap/Makefile A commit references this bug: Author: hselasky Date: Wed Dec 25 09:30:10 UTC 2019 New revision: 356071 URL: https://svnweb.freebsd.org/changeset/base/356071 Log: MFC r355800: Install missing pcap(3) manual pages and add missing manpage section substitutions. Submitted by: Martin Beran <martin@mber.cz> PR: 237893 Sponsored by: Mellanox Technologies Changes: _U stable/11/ stable/11/lib/libpcap/Makefile |