Bug 239659

Summary: mail/claws-mail: Missing dependency dillo2
Product: Ports & Packages Reporter: rozhuk.im
Component: Individual Port(s)Assignee: Chris Hutchinson <portmaster>
Status: Closed Overcome By Events    
Severity: Affects Some People CC: joneum, portmaster, rozhuk.im, salvadore
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Bug Depends on: 245939    
Bug Blocks:    
Attachments:
Description Flags
svn diff for mail/claws-mail: unable litehtml_viewer plugin portmaster: maintainer-approval+

Description rozhuk.im 2019-08-05 16:03:08 UTC
Claws mail team implements "New HTML viewer plugin: Litehtml viewer" but I do not see it installed, but found "dillo" with can show html, and requires to work www/dillo2, that not installed as claws-mail dep.
Comment 1 Kai Knoblich freebsd_committer 2019-08-05 22:23:56 UTC
Assign to maintainer of mail/claws-mail
Comment 2 rozhuk.im 2020-02-19 16:30:01 UTC
ping
Comment 3 Lorenzo Salvadore freebsd_committer 2020-03-10 09:36:29 UTC
I CC the new maintainer of mail/claws-mail (who should probably assign the bug to himself).
Comment 4 Chris Hutchinson 2020-03-10 14:28:51 UTC
(In reply to Lorenzo Salvadore from comment #3)
Thanks for the heads-up, Lorenzo.
I don't have the power to assign this to myself (in
bugzilla). Someone with a ports-mgr hat, like koobs,
for example can tho.
In the meantime. Now that I'm aware of this. I'll
take a closer look, and see how to best resolve this.

Thanks again, Lorenzo!

--Chris
Comment 5 Chris Hutchinson 2020-03-10 17:13:23 UTC
Created attachment 212312 [details]
svn diff for mail/claws-mail: unable litehtml_viewer plugin

The attached svn diff fixes the problem you were
having with the litehtml_viewer plugin.

Thanks for the report!

--Chris
Comment 6 rozhuk.im 2020-03-10 19:23:00 UTC
(In reply to Chris Hutchinson from comment #5)

Thanks!
IMHO there is a bit more changes needed.
dillo plugin requires www/dillo2.
Comment 7 Lorenzo Salvadore freebsd_committer 2020-03-14 09:40:17 UTC
Chris, do you have the power to commit it yourself?
If not I made a mistake by suggesting that you assigned the bug to yourself: bugs should be assigned to committers that make the commit that fixes them. If you cannot do the commit I can do it for you (keep in mind that I am a mentored committer, so this will take a bit more time than it does with normal committers).
Comment 8 Chris Hutchinson 2020-03-14 20:37:20 UTC
(In reply to Lorenzo Salvadore from comment #7)
I have a maintainer hat. I'd also need a portmgr
hat to make the commit. I've received a report
that my patch may still be incomplete. While I
believe the reason to be that the user making
the report was using python v2. I still need to
confirm my theory. I'll be performing some
test cases later today, and make additional
changes, if needed; else confirm my theory.

HTH

--Chris
Comment 9 Chris Hutchinson 2020-04-08 06:32:42 UTC
(In reply to rozhuk.im from comment #6)
OK I've been working on this awhile, and it looks as if
dillo has stoppen being available as a result of the
change to python3. I'm going to dig deeper. But I think
at this point I may upgrade to the newest version of
claws-mail first, and see if I can resolve this problem
then, or immediately after.

Thanks again, for the heads up!

--Chris
Comment 10 Chris Hutchinson 2020-04-08 23:57:20 UTC
version 3.17.5 is out.
See bug #245464

I still havent been able to produce dillo.so. But
am continuing to work on it.

--Chris
Comment 11 rozhuk.im 2020-04-09 06:12:46 UTC
I can dig this after update claws-mail, for now - I dont want install python3.6 :)
Comment 12 rozhuk.im 2020-04-26 16:36:36 UTC
Add port in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=245939
and many other small changes to make claws-mail port more user friendly.