Bug 241565
| Summary: | [NEW PORT] textproc/py-iso3166: Standalone ISO 3166-1 country definitions | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | takefu | ||||||||||||||||||
| Component: | Individual Port(s) | Assignee: | Matthias Andree <mandree> | ||||||||||||||||||
| Status: | Closed FIXED | ||||||||||||||||||||
| Severity: | Affects Only Me | CC: | kevans, mandree, python, vvd | ||||||||||||||||||
| Priority: | --- | Keywords: | feature, needs-patch, needs-qa | ||||||||||||||||||
| Version: | Latest | ||||||||||||||||||||
| Hardware: | Any | ||||||||||||||||||||
| OS: | Any | ||||||||||||||||||||
| URL: | https://pypi.org/project/iso3166/ | ||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||
|
Description
takefu
2019-10-29 05:43:05 UTC
Created attachment 208689 [details] py-iso3166-1.0.shar bug #241564 comment #4 Category changed. misc -> textproc Created attachment 209640 [details]
py-iso-639-0.4.5.shar
category change.
misc -> textproc
Created attachment 209641 [details]
py-iso3166-1.0.shar
Created attachment 213353 [details]
py-iso3166-1.0.1.shar
Version 1.0.1
Please add NO_ARCH=yes and sort USE_PYTHON before commit. (In reply to Matthias Andree from comment #5) > Please add NO_ARCH=yes and sort USE_PYTHON before commit. Like here: https://svnweb.freebsd.org/changeset/ports/532987 Created attachment 213832 [details] py-iso3166-1.0.1.shar Fix: Bug#241565 (In reply to takefu from comment #7) -USE_PYTHON= distutils concurrent autoplist +USE_PYTHON= autoplist concurrent distutils Minor review items:
1) Match COMMENT to setup.py:description (modulo portlint compliance)
2) Package has tests shipped with it. Add TEST_DEPENDS and (do-)test target for better QA accordingly. Ask upstream to package tox.ini and declare tests_require=pytest in setup.py so it makes figuring out how to run tests quicker/easier for downstream consumers (packages *and* users).
The above changes don't require maintainer approval (ports (python) compliance)
@Kyle This needs QA confirmation (including maketest: after (2)) to progress. To assist with the test target, for pytest, the usual caonical and deterministic invocation command is:
do-test:
@cd ${WRKSRC} && ${PYTHON_CMD} -m pytest -v -rs -o addopts=
Created attachment 213833 [details] py-iso3166.shar Sorry Fix: Bug#241565 (In reply to takefu from comment #10) Hi, Just a status notice- we are currently awaiting further action after comments in koobs comment #9 with some review items pointed out. Created attachment 214437 [details] py38-iso3166-1.0.1.shar (In reply to Kyle Evans from comment #11) I put it on, test item. Kyle, ping? Taking, after kevans asked on IRC Thanks everyone for reviews, updates, and nudging, it's in. A commit references this bug: Author: mandree Date: Tue Jun 2 13:12:23 UTC 2020 New revision: 537548 URL: https://svnweb.freebsd.org/changeset/ports/537548 Log: New port: textproc/py-iso3166: Standalone ISO 3166-1 country definitions Self-contained ISO 3166-1 country definitions. WWW: https://pypi.python.org/pypi/iso3166 First user: multimedia/streamlink (kevans@ asked me to handle the commit on Sat May 30 via IRC, I missed it, and he asked again today.) PR: 241565 Submitted by: takefu@airport.fm (maintainer) Reviewed by: koobs@, vvd@unislabs.com Changes: head/textproc/Makefile head/textproc/py-iso3166/ head/textproc/py-iso3166/Makefile head/textproc/py-iso3166/distinfo head/textproc/py-iso3166/pkg-descr |
