Bug 241565 - [NEW PORT] textproc/py-iso3166: Standalone ISO 3166-1 country definitions
Summary: [NEW PORT] textproc/py-iso3166: Standalone ISO 3166-1 country definitions
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Matthias Andree
URL: https://pypi.org/project/iso3166/
Keywords: feature, needs-patch, needs-qa
Depends on:
Blocks:
 
Reported: 2019-10-29 05:43 UTC by takefu
Modified: 2020-06-02 13:13 UTC (History)
4 users (show)

See Also:


Attachments
py-iso3166-1.0.shar (968 bytes, application/x-shellscript)
2019-10-29 05:43 UTC, takefu
no flags Details
py-iso3166-1.0.shar (968 bytes, application/x-shellscript)
2019-10-30 05:08 UTC, takefu
no flags Details
py-iso-639-0.4.5.shar (2.01 KB, application/x-shellscript)
2019-12-03 05:45 UTC, takefu
no flags Details
py-iso3166-1.0.shar (972 bytes, application/x-shellscript)
2019-12-03 05:46 UTC, takefu
no flags Details
py-iso3166-1.0.1.shar (1.03 KB, application/x-sh)
2020-04-13 04:40 UTC, takefu
no flags Details
py-iso3166-1.0.1.shar (1.04 KB, text/plain)
2020-04-26 23:41 UTC, takefu
takefu: maintainer-approval+
Details
py-iso3166.shar (1.04 KB, text/plain)
2020-04-27 01:12 UTC, takefu
takefu: maintainer-approval+
Details
py38-iso3166-1.0.1.shar (1.19 KB, application/x-shellscript)
2020-05-12 23:42 UTC, takefu
takefu: maintainer-approval+
Details

Note You need to log in before you can comment on or make changes to this bug.
Description takefu 2019-10-29 05:43:05 UTC
Created attachment 208670 [details]
py-iso3166-1.0.shar

https://pypi.org/project/iso3166/
Comment 1 takefu 2019-10-30 05:08:21 UTC
Created attachment 208689 [details]
py-iso3166-1.0.shar

bug #241564 comment #4
Category changed.
  misc -> textproc
Comment 2 takefu 2019-12-03 05:45:20 UTC
Created attachment 209640 [details]
py-iso-639-0.4.5.shar

category change.
  misc -> textproc
Comment 3 takefu 2019-12-03 05:46:09 UTC
Created attachment 209641 [details]
py-iso3166-1.0.shar
Comment 4 takefu 2020-04-13 04:40:46 UTC
Created attachment 213353 [details]
py-iso3166-1.0.1.shar

Version 1.0.1
Comment 5 Matthias Andree freebsd_committer 2020-04-25 23:36:03 UTC
Please add NO_ARCH=yes and sort USE_PYTHON before commit.
Comment 6 VVD 2020-04-26 02:41:35 UTC
(In reply to Matthias Andree from comment #5)
> Please add NO_ARCH=yes and sort USE_PYTHON before commit.
Like here: https://svnweb.freebsd.org/changeset/ports/532987
Comment 7 takefu 2020-04-26 23:41:52 UTC
Created attachment 213832 [details]
py-iso3166-1.0.1.shar

Fix: Bug#241565
Comment 8 VVD 2020-04-26 23:51:46 UTC
(In reply to takefu from comment #7)
-USE_PYTHON=	distutils concurrent autoplist
+USE_PYTHON=	autoplist concurrent distutils
Comment 9 Kubilay Kocak freebsd_committer freebsd_triage 2020-04-27 00:50:14 UTC
Minor review items:

1) Match COMMENT to setup.py:description (modulo portlint compliance)
2) Package has tests shipped with it. Add TEST_DEPENDS and (do-)test target for better QA accordingly. Ask upstream to package tox.ini and declare tests_require=pytest in setup.py so it makes figuring out how to run tests quicker/easier for downstream consumers (packages *and* users).

The above changes don't require maintainer approval (ports (python) compliance)

@Kyle This needs QA confirmation (including maketest: after (2)) to progress. To assist with the test target, for pytest, the usual caonical and deterministic invocation command is: 

do-test:
    @cd ${WRKSRC} && ${PYTHON_CMD} -m pytest -v -rs -o addopts=
Comment 10 takefu 2020-04-27 01:12:54 UTC
Created attachment 213833 [details]
py-iso3166.shar

Sorry

Fix: Bug#241565
Comment 11 Kyle Evans freebsd_committer 2020-05-01 04:07:34 UTC
(In reply to takefu from comment #10)

Hi,

Just a status notice- we are currently awaiting further action after comments in koobs comment #9 with some review items pointed out.
Comment 12 takefu 2020-05-12 23:42:56 UTC
Created attachment 214437 [details]
py38-iso3166-1.0.1.shar

(In reply to Kyle Evans from comment #11)

I put it on, test item.
Comment 13 Matthias Andree freebsd_committer 2020-05-24 01:11:48 UTC
Kyle, ping?
Comment 14 Matthias Andree freebsd_committer 2020-06-02 13:00:00 UTC
Taking, after kevans asked on IRC
Comment 15 Matthias Andree freebsd_committer 2020-06-02 13:12:57 UTC
Thanks everyone for reviews, updates, and nudging, it's in.
Comment 16 commit-hook freebsd_committer 2020-06-02 13:13:17 UTC
A commit references this bug:

Author: mandree
Date: Tue Jun  2 13:12:23 UTC 2020
New revision: 537548
URL: https://svnweb.freebsd.org/changeset/ports/537548

Log:
  New port: textproc/py-iso3166: Standalone ISO 3166-1 country definitions

  Self-contained ISO 3166-1 country definitions.

  WWW: https://pypi.python.org/pypi/iso3166

  First user: multimedia/streamlink

  (kevans@ asked me to handle the commit on Sat May 30 via IRC,
  I missed it, and he asked again today.)

  PR:		241565
  Submitted by:	takefu@airport.fm (maintainer)
  Reviewed by:	koobs@, vvd@unislabs.com

Changes:
  head/textproc/Makefile
  head/textproc/py-iso3166/
  head/textproc/py-iso3166/Makefile
  head/textproc/py-iso3166/distinfo
  head/textproc/py-iso3166/pkg-descr