Bug 244162
| Summary: | graphics/gmic-qt: Flavorize the port to support all 3 variants: "gimp", "krita", standalone | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Yuri Victorovich <yuri> | ||||||
| Component: | Individual Port(s) | Assignee: | Yuri Victorovich <yuri> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | CC: | lumiwa, tcberner | ||||||
| Priority: | --- | Flags: | tcberner:
maintainer-feedback+
|
||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| URL: | https://reviews.freebsd.org/D23994 | ||||||||
| See Also: | https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=244161 | ||||||||
| Attachments: |
|
||||||||
Moin moin Sure, sounds doable. I'll look into it. mfg Tobias *** Bug 244161 has been marked as a duplicate of this bug. *** I did solve my problem with gmic-qt. Because I do not krita I just change "krita" with "gimp" and also in pkg-list. It works without problems :). I do not know why I didn't do this year ago... Thank you anywhere. Created attachment 212054 [details] suggested patch The attached patch creates 3 flavors corresponding to the cmake variable GMIC_QT_HOST that this software depends on: * none: builds a standalone application (default flavor) * krita: builds a Krita plugin * gimp: builds a Gimp plugin The flavors can't be installed at the same time pending resolution of https://github.com/c-koi/gmic-qt/issues/83 Moin moin Thanks, you should also update the run-depends in graphics/krita. I'll try to test your patch as soon as possible. mfg Tobias Created attachment 212060 [details]
suggested patch
Patch update:
* Add the change in graphics/krita
* Add the CONFLICTS_INSTALL line.
Comment on attachment 212060 [details]
suggested patch
Thanks :) -- Ship it!
mfg Tobias
(In reply to Tobias C. Berner from comment #7) Thanks! Would you commit it, or should I commit it? Yuri (In reply to Yuri Victorovich from comment #8) You did the work, so you should get the glory :) Thank you very much for the patch. It works and I hope it will come once in the ports too. Flavors committed. A commit references this bug: Author: yuri Date: Sat Sep 5 19:33:17 UTC 2020 New revision: 547673 URL: https://svnweb.freebsd.org/changeset/ports/547673 Log: graphics/gmic-qt: Flavorize the port to support all 3 variants: "gimp", "krita", standalone PR: 244162 Approved by: kde Differential Revision: D23994 Changes: head/graphics/gmic-qt/Makefile head/graphics/gmic-qt/distinfo head/graphics/gmic-qt/pkg-plist |
The GMIC_QT_HOST can be set alternatively to "gimp", "krita" or "none" ("none" would build a standalone version). Currently users who wish to use gmic with gimp can't do so. Please flavorize the port to have all three choices available with different flavors.