|Summary:||net/chrony: Fix linking to nettle and update rc.d script|
|Product:||Ports & Packages||Reporter:||Colin T. <bugzilla>|
|Component:||Individual Port(s)||Assignee:||Matthias Andree <mandree>|
|Severity:||Affects Only Me||CC:||freebsd, mandree, yonas|
|Bug Depends on:||242510, 245399|
Description Colin T. 2020-03-01 06:19:10 UTC
Created attachment 212066 [details] patch Always require pkgconfig instead of only requiring it for NSS Add pidfile to rc.d script to stop it from complaining when stopping chronyd. Document chronyd_* options in rc.d script.
Comment 1 Automation User 2020-03-01 06:36:28 UTC
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/122227075
Comment 2 Colin T. 2020-03-02 07:51:55 UTC
Created attachment 212095 [details] patch-1 Bump PORTREVISION.
Comment 3 Automation User 2020-03-17 00:07:15 UTC
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/126854034
Comment 4 Matthias Andree 2020-04-04 16:27:39 UTC
Hi Colin, what is the purpose of the pkgconfig change, why is it needed? With every option on except NSS, I don't seem to need it.
Comment 5 Colin T. 2020-04-05 16:08:24 UTC
(In reply to Matthias Andree from comment #4) Without pkgconfig, chrony will build fine but won't link to nettle.
Comment 6 Matthias Andree 2020-04-05 20:54:19 UTC
*** Bug 242510 has been marked as a duplicate of this bug. ***
Comment 7 commit-hook 2020-04-05 21:20:58 UTC
A commit references this bug: Author: mandree Date: Sun Apr 5 21:20:11 UTC 2020 New revision: 530840 URL: https://svnweb.freebsd.org/changeset/ports/530840 Log: net/chrony: make NETTLE build robust, improve rc script, re-enable NSS Changes by Colin T.: * Always require pkgconfig instead of only requiring it for NSS, because otherwise chrony does not link reliably to nettle.  * Add pidfile to rc.d script to stop it from complaining when stopping chronyd.  * Document chronyd_* options in rc.d script.  Changes by Matthias Andree: * Move USES line up to please portlint. * Add HTMLDOCS option, to build and install HTML docs. IMPLIES DOCS. Needs textproc/asciidoctor (rubygem) as build requisite. * Turn CRYPTLIB into a _RADIO to choose at most one from NSS + NETTLE. * Under WITH_DEBUG, add --enable-debug to CONFIGURE_ARGS. * Remove @ (silent) from Makefile commands. * Remove NSS_BROKEN, chrony 3.5 appears to work with NSS. Updates . PR: 244534  PR: 242510  PR: 223840  Submitted by: Colin T. <firstname.lastname@example.org>  Reported by: Matt Smith <email@example.com>  Approved by: maintainer timeout (firstname.lastname@example.org, 36 days) Changes: head/net/chrony/Makefile head/net/chrony/files/chronyd.in head/net/chrony/pkg-plist
Comment 8 Matthias Andree 2020-04-05 21:22:12 UTC
Colin, understood and confirmed with poudriere. Building directly from the port picked up nettle for some reason. I have taken the opportunity to mess with the OPTIONS quite a bit to more thoroughly reflect the package behaviour in the options. Thank you for submitting the patch!