Bug 255974
| Summary: | New port: www/civetweb Embedded C/C++ web server | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Frank Scholl <maintainer.freebsd> | ||||||
| Component: | Individual Port(s) | Assignee: | Guangyuan Yang <ygy> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | CC: | diizzy, ygy | ||||||
| Priority: | --- | ||||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 242546 | ||||||||
| Attachments: |
|
||||||||
Hi, You should use DISTVERSION as Porters Handbook instructions you to. https://docs.freebsd.org/en/books/porters-handbook/book.html#makefile-master_sites-github-description DISTVERSIONPREFIX should be set before DISTVERSION - See link above Please define LICENSE_FILE https://docs.freebsd.org/en/books/porters-handbook/book.html#licenses USE_LDCONFIG is missing https://docs.freebsd.org/en/books/porters-handbook/book.html#porting-shlibs Have a look at section "6.5.4. Using cmake" in Porters Handbook, CMAKE_ON / CMAKE_OFF should work instead of using CMAKE_ARGS Looking at the CMake-file these options doesn't seem to be enabled by default, does it make sense to have these enabled especially since they won't pull in any other deps? CIVETWEB_ENABLE_IPV6 , CIVETWEB_ENABLE_ZLIB , CIVETWEB_ENABLE_SSL ? You don't need to define GH_ACCOUNT https://docs.freebsd.org/en/books/porters-handbook/book.html#makefile-master_sites-github-description USE_GITHUB needs to be relocated in the Makefile Give portlint and/or portfmt a spin :-) Does it build using poudriere? Thanks for your submission Best regards, Daniel ...and I forgot, if unit tests works please enable it in the port. Created attachment 225334 [details]
civetweb 1.14
This port got an update to reflect the changes suggested by Daniel:
- DISTVERSIONPREFIX is defined before DISTVERSION
- LICENSE_FILE is added.
- now users CMAKE_ON / CMAKE_OFF instead of using CMAKE_ARGS.
- as suggested, CIVETWEB_ENABLE_IPV6, CIVETWEB_ENABLE_ZLIB, CIVETWEB_ENABLE_SSL are turned on.
- GH_ACCOUNT is not used anymore.
Further information:
- portlint is fine.
- Builds in poudriere (testport), tested for 11.4, 12.2 and 13.0
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=f1e718499cb309115b622453026bbacc4af60d73 commit f1e718499cb309115b622453026bbacc4af60d73 Author: Frank Scholl <maintainer.freebsd@xpoundit.com> AuthorDate: 2021-06-02 02:18:26 +0000 Commit: Guangyuan Yang <ygy@FreeBSD.org> CommitDate: 2021-06-02 02:18:26 +0000 www/civetweb: New port: Embedded C/C++ web server PR: 255974 Approved by: lwhsu (mentor) www/Makefile | 1 + www/civetweb/Makefile (new) | 21 +++++++++++++++++++++ www/civetweb/distinfo (new) | 3 +++ www/civetweb/pkg-descr (new) | 3 +++ www/civetweb/pkg-plist (new) | 11 +++++++++++ 5 files changed, 39 insertions(+) Committed, thanks! |
Created attachment 225061 [details] civetweb 1.14 This port is an embedded C/C++ web server, available as a binary and as a shared library. This port is needed by science/orthanc as a build dependency. While porting science/orthanc, this port was created to integrate science/orthanc and its dependencies into the ports tree as much as possible.