Created attachment 225061 [details]
This port is an embedded C/C++ web server, available as a binary and as a shared library.
This port is needed by science/orthanc as a build dependency. While porting science/orthanc, this port was created to integrate science/orthanc and its dependencies into the ports tree as much as possible.
You should use DISTVERSION as Porters Handbook instructions you to.
DISTVERSIONPREFIX should be set before DISTVERSION - See link above
Please define LICENSE_FILE
USE_LDCONFIG is missing
Have a look at section "6.5.4. Using cmake" in Porters Handbook, CMAKE_ON / CMAKE_OFF should work instead of using CMAKE_ARGS
Looking at the CMake-file these options doesn't seem to be enabled by default, does it make sense to have these enabled especially since they won't pull in any other deps?
CIVETWEB_ENABLE_IPV6 , CIVETWEB_ENABLE_ZLIB , CIVETWEB_ENABLE_SSL ?
You don't need to define GH_ACCOUNT
USE_GITHUB needs to be relocated in the Makefile
Give portlint and/or portfmt a spin :-)
Does it build using poudriere?
Thanks for your submission
...and I forgot, if unit tests works please enable it in the port.
Created attachment 225334 [details]
This port got an update to reflect the changes suggested by Daniel:
- DISTVERSIONPREFIX is defined before DISTVERSION
- LICENSE_FILE is added.
- now users CMAKE_ON / CMAKE_OFF instead of using CMAKE_ARGS.
- as suggested, CIVETWEB_ENABLE_IPV6, CIVETWEB_ENABLE_ZLIB, CIVETWEB_ENABLE_SSL are turned on.
- GH_ACCOUNT is not used anymore.
- portlint is fine.
- Builds in poudriere (testport), tested for 11.4, 12.2 and 13.0
A commit in branch main references this bug:
Author: Frank Scholl <firstname.lastname@example.org>
AuthorDate: 2021-06-02 02:18:26 +0000
Commit: Guangyuan Yang <ygy@FreeBSD.org>
CommitDate: 2021-06-02 02:18:26 +0000
www/civetweb: New port: Embedded C/C++ web server
Approved by: lwhsu (mentor)
www/Makefile | 1 +
www/civetweb/Makefile (new) | 21 +++++++++++++++++++++
www/civetweb/distinfo (new) | 3 +++
www/civetweb/pkg-descr (new) | 3 +++
www/civetweb/pkg-plist (new) | 11 +++++++++++
5 files changed, 39 insertions(+)