Bug 103832 - [PATCH] gxine build fails when /etc/make.conf contains CFLAGS= -O pipe
Summary: [PATCH] gxine build fails when /etc/make.conf contains CFLAGS= -O pipe
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Pav Lucistnik
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-09-30 01:20 UTC by Randy Pratt
Modified: 2006-10-06 23:30 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Randy Pratt 2006-09-30 01:20:17 UTC
When /etc/make.conf contains:
  CFLAGS= -O -pipe
the build will fail with:
if cc -DHAVE_CONFIG_H -I. -I. -I../include -I../include -I../include -I/usr/X11R6/include -I../pixmaps   -I/usr/local/include -I/usr/X11R6/include -I/usr/local/include -std=gnu99 -I/usr/X11R6/include -I/usr/local/include -I/usr/X11R6/include -DXTHREADS -DXUSE_MTSAFE_API -I/usr/local/include/atk-1.0 -I/usr/local/include/cairo -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -I/usr/local/include/freetype2 -I/usr/local/include -I/usr/X11R6/include/gtk-2.0 -I/usr/X11R6/lib/gtk-2.0/include -I/usr/X11R6/include/pango-1.0 -I/usr/X11R6/include   -D_REENTRANT -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -DXP_UNIX -I/usr/local/include/nspr -I/usr/X11R6/include/firefox/js -DLOCALEDIR=\"/usr/X11R6/share/locale\" -O -pipe  -I/usr/local/include -L/usr/local/lib -D_THREAD_SAFE -MT menu.o -MD -MP -MF ".deps/menu.Tpo" -c -o menu.o menu.c; \
	then mv -f ".deps/menu.Tpo" ".deps/menu.Po"; else rm -f ".deps/menu.Tpo"; exit 1; fi
In file included from menu.c:33:
utils.h:92: warning: `sentinel' attribute directive ignored
menu.c: In function `js_Fullscreen_cb':
menu.c:293: sorry, unimplemented: inlining failed in call to 'js_Fullscreen_cb_int': function body not available
menu.c:293: sorry, unimplemented: called from here
gmake[1]: *** [menu.o] Error 1
gmake[1]: Leaving directory `/work/a/ports/multimedia/gxine/work/gxine-0.5.7/src'
gmake: *** [all-recursive] Error 1
*** Error code 2

Stop in /a/ports/multimedia/gxine.

These build failures have also been reported by pointyhat.freebsd.org:
http://portsmon.freebsd.org/portoverview.py?category=multimedia&portname=gxine&wildcard=

Fix: Set CFLAGS in port Makefile to override /etc/make.conf

# diff -ruN multimedia/gxine/Makefile.orig multimedia/gxine/Makefile


The value for CFLAGS in the Makefile was obtained by removing CFLAGS from /etc/make.conf and building the port.  The value for CFLAGS that the port
shows during build was used to make the patch.--CFKWGTka7jZfALaY7G9JWwngXhPlMU8kPLwkGTcSAU5J4DYP
Content-Type: text/plain; name="file.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="file.diff"

--- multimedia/gxine/Makefile.orig      Tue Sep 19 09:09:00 2006
+++ multimedia/gxine/Makefile   Tue Sep 19 09:09:27 2006
@@ -24,6 +24,7 @@
 CONFIGURE_ENV= CPPFLAGS="-I${LOCALBASE}/include -I${X11BASE}/include" \
                LDFLAGS="-L${LOCALBASE}/lib -I${X11BASE}/lib"
 CONFIGURE_ARGS=        --mandir=${PREFIX}/man
+CFLAGS=        -O2 -fno-strict-aliasing -pipe
 INSTALLS_ICONS=        yes
--end of patch--
How-To-Repeat: Use the following in /etc/make.conf :
CFLAGS= -O -pipe
and build.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2006-09-30 11:25:52 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback
Comment 2 Max Brazhnikov 2006-10-04 11:33:49 UTC
I've no any objection.
Please, commit patch.
Comment 3 Pav Lucistnik freebsd_committer freebsd_triage 2006-10-06 22:15:47 UTC
State Changed
From-To: feedback->open
Comment 4 Pav Lucistnik freebsd_committer freebsd_triage 2006-10-06 22:15:47 UTC
Responsible Changed
From-To: freebsd-ports-bugs->pav

Take
Comment 5 dfilter service freebsd_committer freebsd_triage 2006-10-06 23:27:42 UTC
pav         2006-10-06 22:27:36 UTC

  FreeBSD ports repository

  Modified files:
    multimedia/gxine     Makefile 
  Log:
  - Fix build by forcing known good CFLAGS
  
  PR:             ports/103832
  Submitted by:   Randy Pratt <bsd-unix@earthlink.net>
  Approved by:    M. Yu. Brazhnikov <makc@issp.ac.ru> (maintainer)
  
  Revision  Changes    Path
  1.22      +1 -0      ports/multimedia/gxine/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 6 Pav Lucistnik freebsd_committer freebsd_triage 2006-10-06 23:27:43 UTC
State Changed
From-To: open->closed

Committed, thanks!