Bug 104028 - security/stunnel pkg-deinstall doesn't work in batch mode
Summary: security/stunnel pkg-deinstall doesn't work in batch mode
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Peter Pentchev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-10-05 21:00 UTC by jan grant
Modified: 2006-10-08 19:28 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description jan grant 2006-10-05 21:00:40 UTC
/usr/ports/security/stunnel/pkg-deinstall says:

[[[
    if [ -z "${PACKAGE_BUILDING}" -a -z "${BATCH}" ]; then
        read -p "${question} [${default}]? " answer
    fi
]]]

Neither environment variable is typically set. In particular, BATCH=yes may be a _make_ variable (and my pkgtools.conf has this:)

[[[
  MAKE_ARGS = {
       '*/*' => 'BATCH=yes',
]]]

which works with every other port. I don't know if there is actually an environment variable you might make use of, but this behaviour could do with documenting.

Fix: 

Well, a workaround is to supply an appropriate environment as well as the makevar in pkgtools.conf; don't know if this could be engineered to occur in a makefile; I document this in case anyone else bumps into it.
How-To-Repeat: portupgrade -f security/stunnel
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2006-10-05 21:01:06 UTC
Responsible Changed
From-To: freebsd-ports-bugs->roam

Over to maintainer
Comment 2 dfilter service freebsd_committer freebsd_triage 2006-10-08 19:07:41 UTC
roam        2006-10-08 18:06:54 UTC

  FreeBSD ports repository

  Modified files:
    security/stunnel     Makefile 
  Removed files:
    security/stunnel     pkg-deinstall 
  Log:
  Fix the problem with unattended deinstallation by not even attempting
  to remove the stunnel user and group at all - just kill the package
  deinstall script.
  
  PR:             104028
  Reported by:    jan grant <jan.grant@bristol.ac.uk>,
                  Stephen Hurd <shurd@sasktel.net> (in private mail a while ago),
                  and, I think, many others
  
  Revision  Changes    Path
  1.75      +1 -0      ports/security/stunnel/Makefile
  1.3       +0 -63     ports/security/stunnel/pkg-deinstall (dead)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Peter Pentchev freebsd_committer freebsd_triage 2006-10-08 19:27:05 UTC
State Changed
From-To: open->closed

I just committed a change to the stunnel port - now it will no longer 
try to remove the stunnel user and group, ever. 
Thanks for reporting this - actually long-standing - problem!