Bug 105498 - "make index" with NOPORTDOCS=true fails
Summary: "make index" with NOPORTDOCS=true fails
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Stefan Walter
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-11-14 00:30 UTC by Mark Andrews
Modified: 2006-11-18 19:30 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Andrews 2006-11-14 00:30:02 UTC
	Ports "make index" with NOPORTDOCS=true fails.

bsdi# make index
Generating INDEX - please wait.."Makefile", line 44: Unassociated shell command "${RM} -rf ${WRKSRC}/doc"
make: fatal errors encountered -- cannot continue
===> devel/ice failed
*** Error code 1
1 error

********************************************************************
Before reporting this error, verify that you are running a supported
version of FreeBSD (see http://www.FreeBSD.org/ports/) and that you
have a complete and up-to-date ports collection.  (INDEX builds are
not supported with partial or out-of-date ports collections -- in
particular, if you are using cvsup, you must cvsup the "ports-all"
collection, and have no "refuse" files.)  If that is the case, then
report the failure to ports@FreeBSD.org together with relevant
details of your ports configuration (including FreeBSD version,
your architecture, your environment, and your /etc/make.conf
settings, especially compiler flags and WITH/WITHOUT settings).

Note: the latest pre-generated version of INDEX may be fetched
automatically with "make fetchindex".
********************************************************************

*** Error code 1

Stop in /scratch/ports.
*** Error code 1

Stop in /scratch/ports.

Fix: 

I presume 

		.if defined(NOPORTDOCS)
			${RM} -rf ${WRKSRC}/doc
		.endif

	needs to me moved into post-patch however I don't use this port.
How-To-Repeat: 
	Add NOPORTDOCS=true to /etc/make.conf and run "make index"
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2006-11-14 01:46:36 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback
Comment 2 Stefan Ehmann 2006-11-14 12:53:08 UTC
I'd prefer the following fix:

--- ice.bak/Makefile	Tue Nov 14 13:45:31 2006
+++ ice/Makefile	Tue Nov 14 13:37:47 2006
@@ -41,7 +41,7 @@
 .endif
 
 .if defined(NOPORTDOCS)
-	${RM} -rf ${WRKSRC}/doc
+MAKE_ENV+=	NOPORTDOCS=yes
 .endif
 
 post-patch:
Comment 3 Stefan Walter freebsd_committer freebsd_triage 2006-11-18 17:20:54 UTC
Responsible Changed
From-To: freebsd-ports-bugs->stefan

Take.
Comment 4 Stefan Walter freebsd_committer freebsd_triage 2006-11-18 19:21:22 UTC
State Changed
From-To: feedback->closed

Fix committed, thanks!
Comment 5 dfilter service freebsd_committer freebsd_triage 2006-11-18 19:24:22 UTC
stefan      2006-11-18 19:20:38 UTC

  FreeBSD ports repository

  Modified files:
    devel/ice            Makefile 
  Log:
  Fix port for cases in which NOPORTDOCS is defined.
  
  PR:             105498
  Submitted by:   Mark Andrews <Mark_Andrews@isc.org>
  Patch by:       maintainer
  
  Revision  Changes    Path
  1.10      +1 -1      ports/devel/ice/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"