Bug 107941 - games/nethack34 - Add WITH_HPMON, cleanup removal of lib/nethack when savegames exist
Summary: games/nethack34 - Add WITH_HPMON, cleanup removal of lib/nethack when savegam...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Jeremy Chadwick
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-01-15 08:00 UTC by Jeremy Chadwick
Modified: 2007-01-22 13:36 UTC (History)
1 user (show)

See Also:


Attachments
file.diff (2.23 KB, patch)
2007-01-15 08:00 UTC, Jeremy Chadwick
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Chadwick freebsd_committer 2007-01-15 08:00:47 UTC
	Patch does the following:

	* Add WITH_HPMON support (author: Ralph Churchill).  This
	  colourises your hitpoints as they decrease.  Official diff:
	  http://www.netsonic.fi/~walker/nh/hpmon.diff
	* Addresses the situation where there's existing save games
	  (in PREFIX/lib/nethack/save).  Prior to this patch, pkg_delete
	  or deinstalling would result in the "could not remove
	  PREFIX/lib/nethack" message.
	  This is now addressed by echo'ing some useful comments to the
	  user when failing to rmdir PREFIX/lib/nethack/save, and using
	  @dirrmtry on the PREFIX/lib/nethack directory.

	CC'ing glewis so he can put a copy of hpmon.diff in his directory
	on MASTER_SITE_LOCAL.  (We can fix the PATCH_SITES after that's
	done.)

Fix: Apply below patch.
How-To-Repeat: 	n/a
Comment 1 Edwin Groothuis freebsd_committer 2007-01-15 08:00:58 UTC
Class Changed
From-To: maintainer-update->change-request

Fix category (submitter is not maintainer)
Comment 2 Edwin Groothuis freebsd_committer 2007-01-15 08:01:05 UTC
Responsible Changed
From-To: freebsd-ports-bugs->koitsu

Submitter has GNATS access
Comment 3 Edwin Groothuis freebsd_committer 2007-01-15 08:01:12 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback
Comment 4 dfilter service freebsd_committer 2007-01-15 15:57:31 UTC
koitsu      2007-01-15 15:57:21 UTC

  FreeBSD ports repository

  Modified files:
    games/nethack34      Makefile distinfo pkg-plist 
  Log:
  Committed.
  
  PR:             107941
  Approved by:    philip
  
  Revision  Changes    Path
  1.57      +7 -1      ports/games/nethack34/Makefile
  1.18      +3 -0      ports/games/nethack34/distinfo
  1.16      +3 -3      ports/games/nethack34/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 5 Jeremy Chadwick freebsd_committer 2007-01-15 15:58:49 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!

Approved by: philip
Comment 6 dfilter service freebsd_committer 2007-01-15 17:24:39 UTC
koitsu      2007-01-15 17:24:34 UTC

  FreeBSD ports repository

  Modified files:
    games/nethack34      Makefile 
  Log:
  Details of previous commit:
  
  * Add WITH_HPMON support - colourises hitpoints as they decrease.
  * Address issue where uninstalling with existing save games in
    place (PREFIX/lib/nethack/save/*) would result in a "Could not
    remove PREFIX/lib/nethack" error.  Now echoes some useful
    comments to the user when failing to rmdir PREFIX/lib/nethack/save,
    and using @dirrmtry on the PREFIX/lib/nethack directory.
  
  Also added:
  
  * Reference MASTER_SITE_LOCAL for hpmon.diff, in the case the
    main patch site isn't available.
  
  PR:             ports/107941
  Approved by:    philip
  
  Revision  Changes    Path
  1.58      +2 -1      ports/games/nethack34/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 7 Jeremy Chadwick freebsd_committer 2007-01-22 13:36:06 UTC
State Changed
From-To: feedback->closed

Committed, with minor changes. Thanks!