If e.g. PACKAGE_BUILDING is defined, you will not be able to build print/hplip without x11-toolkits/py-qt . quote from the porters handbook: "Due to a deficiency in the infrastructure, you can only test WITH_* variables for options which are OFF by default, and WITHOUT_* variables for options which default to ON." So test for WITHOUT_GUI and not for WITH_GUI in the hplip Makefile. Fix: -.if defined(WITH_GUI) +.if !defined(WITHOUT_GUI) RUN_DEPENDS+= pylupdate:${PORTSDIR}/x11-toolkits/py-qt .endif--DkgQTNR9NVV0cRjDfG6oicfBRl6xquYXC8FFlG25FzI2Iyzb Content-Type: text/plain; name="file.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="file.diff" Index: Makefile =================================================================== RCS file: /home/ncvs/ports/print/hplip/Makefile,v retrieving revision 1.7 diff -u -r1.7 Makefile --- Makefile 27 Sep 2006 23:00:09 -0000 1.7 +++ Makefile 18 Jan 2007 18:33:42 -0000 @@ -52,7 +52,7 @@ WITH_GUI= yes .endif How-To-Repeat: Set PACKAGE_BUILDING=yes and try now to build print/hplip without x11-toolkits/py-qt.
State Changed From-To: open->feedback Awaiting maintainers feedback
I forgot the check for pylupdate. Maybe this one? Index: Makefile =================================================================== RCS file: /home/ncvs/ports/print/hplip/Makefile,v retrieving revision 1.7 diff -u -r1.7 Makefile --- Makefile 27 Sep 2006 23:00:09 -0000 1.7 +++ Makefile 18 Jan 2007 21:16:24 -0000 @@ -48,11 +48,7 @@ USE_AUTOTOOLS= automake:19:env autoconf:259:env aclocal:19:env .endif -.if exists(${LOCALBASE}/bin/pylupdate) -WITH_GUI= yes -.endif - -.if defined(WITH_GUI) +.if !defined(WITHOUT_GUI) || exists(${LOCALBASE}/bin/pylupdate) RUN_DEPENDS+= pylupdate:${PORTSDIR}/x11-toolkits/py-qt .endif
Responsible Changed From-To: freebsd-ports-bugs->itetcu OPTIONS ! I like them :-)
State Changed From-To: feedback->closed Superceeded by 108278