Bug 108669 - imlib2 doesn't build without X11
Summary: imlib2 doesn't build without X11
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Stanislav Sedov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-02-01 22:40 UTC by Peter Koeleman
Modified: 2007-02-05 22:00 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Koeleman 2007-02-01 22:40:16 UTC
	Configuring graphics/imlib2-20060926 from ports without X11 will make the configure script break.
The port will correctly use the --without-x switch but the configure script still can't find X11 libs and
headers (no surprise there) but also cannot tell that --without-x was used.
Exerpt from the configure script:

if test "x$have_x" = "xno"; then
   # If --without-x was passed, this will be "disabled" instead of "no" --
   # so always treat "no" as an error
   { { echo "$as_me:$LINENO: error: no X support found.  Use --x-includes and --x-libraries to specify the X
path on your system, or --without-x to disable X support." >&5
echo "$as_me: error: no X support found.  Use --x-includes and --x-libraries to specify the X
path on your system, or --without-x to disable X support." >&2;}
   { (exit 1); exit 1; }; }
fi

This would make you think that the switch is used correctly but still the variable $have_x has value "no",
even with the --without-x switch.

Fix: Editing the configure script and inserting the line:
have_x="disabled"
makes imlib2 configure and build, this is what the script expects.

Diff:



-have_x="disabled"
+

 if test "x$have_x" = "xno"; then
    # If --without-x was passed, this will be "disabled" instead of "no" ----QhNRyKwwDGUd6uVR1HKRe0xbZl5pK25Ohsxl7WMBvDj6eyH3
Content-Type: text/plain; name="file.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="file.diff"

--- configure   Thu Feb  1 22:01:02 2007
+++ configure.bak       Tue Sep 26 21:18:02 2006
@@ -21542,7 +21542,7 @@
    have_x="no"
 fi
How-To-Repeat: 	1) Do not install X11 libraries and headers or uninstall them.
	2) put WITHOUT_X11=yes in /etc/make.conf
	3) cd to /usr/ports/graphics/imlib2
	4) run make as root
	5) Get error message about missing X11 stuff
Comment 1 Edwin Groothuis freebsd_committer 2007-02-02 09:55:36 UTC
Responsible Changed
From-To: freebsd-ports-bugs->stas

Over to maintainer
Comment 2 Stanislav Sedov freebsd_committer 2007-02-05 21:55:39 UTC
State Changed
From-To: open->closed

Committed. Thanks!
Comment 3 dfilter service freebsd_committer 2007-02-05 21:55:54 UTC
stas        2007-02-05 21:55:12 UTC

  FreeBSD ports repository

  Added files:
    graphics/imlib2/files patch-configure 
  Log:
  - Fix non-X11 building.
  
  PR:                     ports/108669
  Submitted by:           Peter Koeleman <peter@peerweb.nl>
  Reported also by:       Morten Jorgensen <mojo@unixnet.dk>
  
  Revision  Changes    Path
  1.6       +11 -0     ports/graphics/imlib2/files/patch-configure (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"