Bug 113383 - [PATCH] security/ipsec-tools: fix build with gcc 4.2
Summary: [PATCH] security/ipsec-tools: fix build with gcc 4.2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Rong-En Fan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-06-05 18:20 UTC by Rong-En Fan
Modified: 2007-07-02 18:10 UTC (History)
1 user (show)

See Also:


Attachments
ipsec-tools-0.6.7.patch (2.38 KB, patch)
2007-06-05 18:20 UTC, Rong-En Fan
no flags Details | Diff
smime.p7s (3.31 KB, application/x-pkcs7-signature)
2007-06-06 10:31 UTC, VANHULLEBUS Yvan
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Rong-En Fan freebsd_committer freebsd_triage 2007-06-05 18:20:00 UTC
- Fix build with gcc 4.2. Tested on i386 current.
- Remove blank line in distinfo

Added file(s):
- files/patch-src__racoon__eaytest.c
- files/patch-src__racoon__var.h

Port maintainer (vanhu@netasq.com) is cc'd.

Generated with FreeBSD Port Tools 0.77
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2007-06-05 18:20:10 UTC
Responsible Changed
From-To: freebsd-ports-bugs->rafan

Submitter has GNATS access
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2007-06-05 18:20:18 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback
Comment 3 VANHULLEBUS Yvan 2007-06-06 10:31:08 UTC
On Tue, Jun 05, 2007 at 05:20:15PM +0000, Edwin Groothuis wrote:
> Maintainer of security/ipsec-tools,
> 
> Please note that PR ports/113383 has just been submitted.
> 
> If it contains a patch for an upgrade, an enhancement or a bug fix
> you agree on, reply to this email stating that you approve the patch
> and a committer will take care of it.
> 
> The full text of the PR can be found at:
>     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/113383


Patch is ok, but as it is low/non-critical, and as we are about to
release ipsec-tools 0.7 (which will be of course used in the ports
when it will be out), I guess it would be simpler to just report it in
ipsec-tools 0.7 (which will be done today anyways) and NOT create
those two extra patches for the port just for a few days/weeks.

But if commiters don't care about adding files they'll have to remove
in a few weeks max, or if some people needs this to be fixed really
fast, it's ok for me.



Yvan.

-- 
NETASQ
http://www.netasq.com
Comment 4 Rong-En Fan freebsd_committer freebsd_triage 2007-06-06 15:43:57 UTC
Okay, if there are people asking for fixing this
then I will commit the patches. Otherwise, I will
just wait for 0.7.
Comment 5 Pav Lucistnik freebsd_committer freebsd_triage 2007-07-02 17:45:55 UTC
Please commit the patches. A month wait was long enough. Thanks.

-- 
Pav Lucistnik <pav@oook.cz>
              <pav@FreeBSD.org>

Any sufficiently advanced technology is indistinguishable from magic.
  -- Arthur C. Clarke
Comment 6 dfilter service freebsd_committer freebsd_triage 2007-07-02 18:00:17 UTC
rafan       2007-07-02 17:00:01 UTC

  FreeBSD ports repository

  Modified files:
    security/ipsec-tools distinfo 
    security/ipsec-tools/files patch-configure 
                               patch-src__racoon__plog.c 
  Added files:
    security/ipsec-tools/files patch-src__racoon__eaytest.c 
                               patch-src__racoon__var.h 
  Log:
  - Fix build with gcc 4.x
  - While I'm here, remove extra empty line in distinfo
  
  PR:            ports/113383
  Submitted by:  rafan
  Approved by:   VANHULLEBUS Yvan <yvan.vanhullebus at netasq.com> (maintainer)
  
  Revision  Changes    Path
  1.9       +0 -1      ports/security/ipsec-tools/distinfo
  1.4       +19 -6     ports/security/ipsec-tools/files/patch-configure
  1.1       +20 -0     ports/security/ipsec-tools/files/patch-src__racoon__eaytest.c (new)
  1.2       +3 -4      ports/security/ipsec-tools/files/patch-src__racoon__plog.c
  1.1       +23 -0     ports/security/ipsec-tools/files/patch-src__racoon__var.h (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 7 Rong-En Fan freebsd_committer freebsd_triage 2007-07-02 18:00:18 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!