Bug 113682 - [patch] sysinstall(8) warns for invalid geometry which is not
Summary: [patch] sysinstall(8) warns for invalid geometry which is not
Status: Closed Overcome By Events
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: Unspecified
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-sysinstall (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-06-14 15:50 UTC by Cedric GROSS
Modified: 2015-11-10 09:12 UTC (History)
0 users

See Also:

Attachments
file.diff (620 bytes, patch)
2007-06-14 15:50 UTC, Cedric GROSS 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Cedric GROSS 2007-06-14 15:50:02 UTC 
When running install with HDD > 32Gb slice editor warn a geometry of
xxx/xxx/255 is invalid which is not.

In fact, condition for showing message and sanitize the geometry is
wrong and should be same as for PC98 configuration.

Also, Sanitize_Bios_Geom in  src/lib/libdisk/change.c should be changed
because we first test for head<16 and for HDD >32Gb we reach head=255
(SCSI Setting).

Seems that Sanitize is base on the 528Mb barrier (1024/16/63)

Fix: Review print_chunks in src/usr.sbin/sysinstall/disks.c (patch included) and
review Sanitize_Bios_Geom in src/lib/libdisk/change.c 

Patch attached with submission follows:
How-To-Repeat: Use disk with capacity > 32Gb and run slice editor on it.
Comment 1 Bruce Cran freebsd_committer freebsd_triage 2010-04-30 20:04:44 UTC 
Responsible Changed
From-To: freebsd-bugs->brucec

Take
Comment 2 Bruce Cran freebsd_committer freebsd_triage 2011-01-23 21:14:29 UTC 
Responsible Changed
From-To: brucec->freebsd-sysinstall

Back to the pool.
Comment 3 Enji Cooper freebsd_committer freebsd_triage 2015-11-10 09:07:53 UTC 
sysinstall has been replaced by bsdinstall in FreeBSD 9.x. Closing.
Comment 4 Enji Cooper freebsd_committer freebsd_triage 2015-11-10 09:12:29 UTC 
sysinstall has been replaced by bsdinstall in FreeBSD 9.x. Closing.