Bug 114036 - [PATCH] graphics/GraphicsMagick: add WITHOUT_SYMBOL_PREFIX knob & fix webfonts path
Summary: [PATCH] graphics/GraphicsMagick: add WITHOUT_SYMBOL_PREFIX knob & fix webfont...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Stanislav Sedov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-06-26 13:00 UTC by Roderick van Domburg
Modified: 2007-07-16 19:54 UTC (History)
0 users

See Also:


Attachments
GraphicsMagick-symbol-prefix-knob.patch (931 bytes, patch)
2007-06-26 13:00 UTC, Roderick van Domburg
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Roderick van Domburg 2007-06-26 13:00:07 UTC
The GraphicsMagick port has been set to compile with the 'Gm' symbol prefix as of July 31st, 2006. Even after a year not all depending packages have been updated to work with that and, indeed, it is not always trivial to do so (ruby-rmagick being one example).

This patch adds a WITHOUT_SYMBOL_PREFIX knob to compile it The Old Way to guarantee compatibility with non-updated packages. By having this as a knob instead of an option, it serves for expert use only.

(Also see the ruby-rmagick update I will be submitting next.)

While we're there, also fix the default path to the webfonts.

How-To-Repeat: 1. Install GraphicsMagick
2. Try to install ruby-rmagick with GraphicsMagick
Comment 1 Stanislav Sedov freebsd_committer 2007-07-16 15:21:57 UTC
Responsible Changed
From-To: freebsd-ports-bugs->stas

I'll take it.
Comment 2 dfilter service freebsd_committer 2007-07-16 19:30:34 UTC
stas        2007-07-16 18:30:28 UTC

  FreeBSD ports repository

  Modified files:
    graphics/GraphicsMagick Makefile 
  Added files:
    graphics/GraphicsMagick/files patch-magick_symbols.h 
  Log:
  - Do not redefine GraphicsMagick symbols, since it causes problems with
    some ports, that expect standard Magick symbols to be present (that is
    revert revision 1.6). Redefine only the GetToken symbol instead just to
    get rid of ports/94905
  - Use correct path for windows fonts [1]
  - Add a knob to depend on windows fonts conditionally.
  
  PR:             ports/114036 [1]
  Submitted by:   Roderick van Domburg <r.s.a.vandomburg@nedforce.nl>
  
  Revision  Changes    Path
  1.13      +8 -5      ports/graphics/GraphicsMagick/Makefile
  1.1       +19 -0     ports/graphics/GraphicsMagick/files/patch-magick_symbols.h (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Stanislav Sedov freebsd_committer 2007-07-16 19:54:53 UTC
State Changed
From-To: open->closed

The fix was committed.