Bug 114356 - [patch] ports/www/lynx WITHOUT_NLS correction
Summary: [patch] ports/www/lynx WITHOUT_NLS correction
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-07-06 14:30 UTC by Helge Oldach
Modified: 2007-07-26 18:10 UTC (History)
0 users

See Also:

Attachments
file.diff (697 bytes, patch)
2007-07-06 14:30 UTC, Helge Oldach 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Helge Oldach 2007-07-06 14:30:03 UTC 
ports/www/lynx can be compiled with or without NLS, using the
WITHOUT_NLS knob. However, libiconv is unconditionally compiled in,
although it is just superfluous unless NLS is requested. Indeed lynx
runs just fine without libiconv, and actually isn't even linked against
libiconv.

The rather simple patch below fixes the issue.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2007-07-06 14:30:14 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback
Comment 2 Rong-En Fan freebsd_committer freebsd_triage 2007-07-26 18:09:46 UTC 
State Changed
From-To: feedback->closed

Committed. Thanks!
Comment 3 dfilter service freebsd_committer freebsd_triage 2007-07-26 18:09:48 UTC 
rafan       2007-07-26 17:09:41 UTC

  FreeBSD ports repository

  Modified files:
    www/lynx             Makefile 
  Log:
  - Since iconv is used only for i18n stuff, put it under !defined(WITHOUT_NLS)
    section.
  
  PR:             ports/114356
  Submitted by:   Helge Oldach <ports-www-lynx-jul07 at oldach.net>
  Approved by:    maintainer timeout (20 days)
  
  Revision  Changes    Path
  1.125     +3 -3      ports/www/lynx/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"