Bug 118355 - [pf] [patch] pfctl(8) help message options order false -t must before -T
Summary: [pf] [patch] pfctl(8) help message options order false -t must before -T
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: 5.5-STABLE
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-bugs (Nobody)
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2007-11-30 16:50 UTC by Alexander
Modified: 2019-04-10 11:56 UTC (History)
1 user (show)

See Also:


Attachments
file.diff (535 bytes, patch)
2007-11-30 16:50 UTC, Alexander
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander 2007-11-30 16:50:00 UTC
If I try to add a entry in a pf table the option -T must follow -t so this command fails:

% sudo pfctl -T add 86.51.7.205 -t badhosts
No ALTQ support in kernel
ALTQ related functions disabled
usage: pfctl [-AdeghNnOqRrvz] [-a anchor[:ruleset]] [-D macro=value]
             [-F modifier] [-f file] [-i interface] [-k host] [-p device]
             [-s modifier] [-T command [address ...]] [-t table] [-x level]
%

The help message does display the -t option behind -T.

I think it would be help to see the options in the right order.

Also the order in the manpage is to be corrected, but I don't know the syntax.

How-To-Repeat: pfctl -T add 86.51.7.205 -t badhosts
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2007-11-30 21:05:03 UTC
Responsible Changed
From-To: freebsd-bugs->freebsd-pf

Over to maintainer(s).
Comment 2 Eitan Adler freebsd_committer freebsd_triage 2017-12-31 08:01:10 UTC
For bugs matching the following criteria:

Status: In Progress Changed: (is less than) 2014-06-01

Reset to default assignee and clear in-progress tags.

Mail being skipped
Comment 3 Andriy Voskoboinyk freebsd_committer freebsd_triage 2019-04-10 11:56:07 UTC
Fixed in base r145837 (man page) / base r145840 (usage help in program).