Bug 119447 - [patch] net-im/ysm - charset conversion does not work
[patch] net-im/ysm - charset conversion does not work
Status: Closed FIXED
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s)
Latest
Any Any
: Normal Affects Only Me
Assigned To: Sergey Matveychuk
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-01-08 12:30 UTC by eugen
Modified: 2008-01-12 19:50 UTC (History)
1 user (show)

See Also:


Attachments
file.diff (497 bytes, patch)
2008-01-08 12:30 UTC, eugen
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description eugen 2008-01-08 12:30:01 UTC
	
	The ICQ console client net-im/ysm has built-in charset conversion
	capability that may be turned on using its config file.
	Sadly, it does not work - does convert anything.

Fix: Make directory /usr/ports/net-im/ysm/files and place
	the following patch there. This information found here:

http://sourceforge.net/tracker/index.php?func=detail&aid=1850213&group_id=44296&atid=439086

	Verified, it solves the problem.
How-To-Repeat: 	Install ysm using ports, run it - it makes ~/.ysm/ysm-cfg.
	Read comments about CHARSET_TRANS and CHARSET_LOCAL there.
	Make changes to the config (example is for Russian language):

CHARSET_TRANS>CP1251
CHARSET_LOCAL>KOI8-R

	Then try to use ysm. It won't translate anything.
Comment 1 eugen 2008-01-08 12:48:40 UTC
Hi!

I've CC'd this PR to maintainer's e-mail but it has bounced:

   ----- The following addresses had permanent fatal errors -----
<aquatique-ports@rambler.ru>
    (reason: 540 <aquatique-ports@rambler.ru>: Recipient address rejected:
Your emails has been returned because ...t's email account has been suspended.
The account must be re-activated to receive incoming messages.)

So, maintainer won't respond on the PR.

Eugene Grosbein
Comment 2 eugen 2008-01-08 17:21:24 UTC
Hi!

Another patch to make ysm more usable. It switches readline
to "vi-insert" editing mode instead of default and more common "emacs".
One could workaround this with the following section in ~/.inputrc:

$if ysm
  set editing-mode emacs
  set horizontal-scroll-mode off
$endif

But ysm does not inform readline about its name, hence the patch
for files/ directory. One may use ~/.ysm/inputrc file for readline settings
dedicated for ysm but centralized ~/.inputrc should be supported too,

--- src/YSM_Prompt.c.orig	Tue Jan  8 23:37:16 2008
+++ src/YSM_Prompt.c	Wed Jan  9 00:10:32 2008
@@ -564,6 +564,11 @@
 	YSM_ConsoleRestore();
 
 	/* Set default readline values */
+
+	rl_readline_name = "ysm";
+	using_history();
+	unstifle_history();
+
 	rl_variable_bind("editing-mode", "emacs");
 	rl_bind_key('\t', YSM_ConsoleTabHook);	/* Tab hook for emacs */
 	/* ysm hot keys */
Comment 3 Edwin Groothuis freebsd_committer 2008-01-08 21:53:15 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 4 Sergey Matveychuk freebsd_committer 2008-01-12 17:30:19 UTC
Responsible Changed
From-To: freebsd-ports-bugs->sem

Take it.
Comment 5 dfilter freebsd_committer 2008-01-12 19:46:59 UTC
sem         2008-01-12 19:46:54 UTC

  FreeBSD ports repository

  Modified files:
    net-im/ysm           Makefile 
  Added files:
    net-im/ysm/files     patch-src-YSM_Charset.c 
                         patch-src-YSM_Prompt.c 
  Log:
  Add two patches:
  - Fix iconv() arguments to make conversions correct.
  - Add an application name for readline. It allows to set options for readline
    from user config files*. And enable history.
  
  * example ~/.inputrc:
  $if ysm
  set editing-mode emacs
  set horizontal-scroll-mode off
  $endif
  
  PR:             ports/119447
  Submitted by:   Eugene Grosbein <eugen at kuzbass.ru>
  
  Revision  Changes    Path
  1.23      +2 -1      ports/net-im/ysm/Makefile
  1.1       +15 -0     ports/net-im/ysm/files/patch-src-YSM_Charset.c (new)
  1.1       +13 -0     ports/net-im/ysm/files/patch-src-YSM_Prompt.c (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 6 Sergey Matveychuk freebsd_committer 2008-01-12 19:50:10 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!