Attached patch against Makefile makes dependency on ogg vorbis in mp3splt optional.
Fix: Patch attached with submission follows:
Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
I do approve the patch, but I'm curious at your reasoning for the patch.
The libvorbis package is merely 600kB on my system and anybody doing
serious MP3 and audio manipulation will have both, libogg and libvorbis
So, I find it rather pointless in adding this option, but if you have a
good use for it, I'm not gonna stand in the way.
Maintainer approved, but see audit trail.
I don't have a single ogg file on any of my computers. Yet I have, as
do you, both libogg and libvorbis installed. I use mp3splt to trim
crossfading from mp3 files I obtain with streamripper, and I don't see
ogg/vorbis getting popular for streaming radio any time soon. My
laptop however is rather low on memory, and loading unnecessary
libraries contributes to slow performance. Clearly one library in one
application won't make a big splash, but systematically making
optional dependencies truly optional will have a substantial impact.
Consider redhat vs debian -- the fact that deb provides for optional
dependencies tends to make debian-based installations noticeably
I'll take it
beech 2008-02-03 04:43:18 UTC
FreeBSD ports repository
- Add option (ogg vorbis)
Submitted by: Oleg Pudeyev <email@example.com>
Approved by: Ulrich Spoerlein <firstname.lastname@example.org> (maintainer)
Revision Changes Path
1.20 +13 -5 ports/audio/mp3splt/Makefile
email@example.com mailing list
To unsubscribe, send any mail to "firstname.lastname@example.org"