Bug 120521 - [PATCH] print/libgnomeprint: Respect if user wants to disable CUPS
Summary: [PATCH] print/libgnomeprint: Respect if user wants to disable CUPS
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-gnome (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-02-11 06:00 UTC by Naram Qashat
Modified: 2008-02-12 21:50 UTC (History)
1 user (show)

See Also:

Attachments
libgnomeprint-2.18.3.patch (587 bytes, patch)
2008-02-11 06:00 UTC, Naram Qashat 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Naram Qashat 2008-02-11 06:00:06 UTC 
- Respect if the user has defined WITHOUT_CUPS when they want to disable
  CUPS within libgnomeprint.

Port maintainer (gnome@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.77
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2008-02-11 06:00:14 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->gnome

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2008-02-12 21:41:13 UTC 
mezz        2008-02-12 21:41:07 UTC

  FreeBSD ports repository

  Modified files:
    print/libgnomeprint  Makefile distinfo 
  Log:
  -Update to 2.18.4.
  -Respect the WITHOUT_CUPS with auto-check. [1]
  
  PR:             ports/120521
  Submitted by:   Naram Qashat <cyberbotx@cyberbotx.com>
  
  Revision  Changes    Path
  1.110     +2 -2      ports/print/libgnomeprint/Makefile
  1.51      +3 -3      ports/print/libgnomeprint/distinfo
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Jeremy Messenger freebsd_committer freebsd_triage 2008-02-12 21:42:09 UTC 
State Changed
From-To: open->closed

Committed, thanks! There was a typo, GUPS -> CUPS and it's best to have this 

if (defined(WITH_CUPS) || exists(${LOCALBASE}/lib/libcups.so)) && !defined(WITHOUT_CUPS) 

than this: 

.if defined(WITH_CUPS) || (exists(${LOCALBASE}/lib/libcups.so) && !defined(WITHOUT_CUPS))