Bug 123367 - [maintainer] net-mgmt/collectd various fixes and improvements
Summary: [maintainer] net-mgmt/collectd various fixes and improvements
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Ion-Mihai "IOnut" Tetcu
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-05-03 15:30 UTC by Daniel Roethlisberger
Modified: 2008-05-06 11:50 UTC (History)
1 user (show)

See Also:


Attachments
collectd-improve.diff (10.47 KB, patch)
2008-05-03 15:30 UTC, Daniel Roethlisberger
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Roethlisberger 2008-05-03 15:30:01 UTC
Note that I am not maintainer according to CVS yet, but the
former maintainer Matt Peterson has already agreed to hand
over maintainership in PR ports/122791, which has not been
committed yet.  Therefore, this PR depends on PR 122791:
http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/122791

This patch improves some rough edges about the collectd port:
. Do not delete modified config files on uninstall
. Reduce filesystem hierarchy pollution by moving
  $PREFIX/var/{run,lib}/* to /var/run (PID file) and
  /var/db/collectd (default location of databases)
. Add an rc script for collectd
. Optionally install collection.cgi from contrib/
. Fix dependencies, general cleanup

New files: files/*

Please also add a note to UPDATING:
  AFFECTS: users of net-mgmt/collectd
  AUTHOR: daniel@roe.ch

  Previously, net-mgmt/collectd used to remove the config file
  even if it was changed by the user.  This has now been fixed.
  To upgrade without losing your configuration, copy the file
  ${PREFIX}/etc/collectd.conf away to a safe place before
  upgrading net-mgmt/collectd.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2008-05-03 15:30:10 UTC
Class Changed
From-To: maintainer-update->change-request

Fix category (submitter is not maintainer) (via the GNATS Auto Assign 
Tool)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2008-05-03 15:30:13 UTC
Maintainer of net-mgmt/collectd,

Please note that PR ports/123367 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/123367

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 Edwin Groothuis freebsd_committer freebsd_triage 2008-05-03 15:30:17 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 4 Ion-Mihai "IOnut" Tetcu freebsd_committer freebsd_triage 2008-05-04 20:42:24 UTC
Responsible Changed
From-To: freebsd-ports-bugs->itetcu

I'll take it.
Comment 5 dfilter service freebsd_committer freebsd_triage 2008-05-06 11:45:24 UTC
itetcu      2008-05-06 10:45:17 UTC

  FreeBSD ports repository

  Modified files:
    net-mgmt/collectd    Makefile pkg-descr pkg-plist 
  Added files:
    net-mgmt/collectd/files collectd.in patch-src__collectd.h 
  Log:
  - Transfer maintainership to daniel@roe.ch [1]
  - Do not delete modified config files on uninstall [2]
  - Reduce filesystem hierarchy pollution by moving
    $PREFIX/var/{run,lib}/* to /var/run (PID file) and
    /var/db/collectd (default location of databases) [2]
  - Add an rc script [2]
  - Optionally install collection.cgi from contrib/ [2]
  - Fix WITH_APACHE dependencies and plist [1]
  - Fix WITH_XMMS and WITH_INTERFACE dependencies [2]
  - fixes for depends, plist, ... [3]
  
  PR:             ports/122791 [1], ports/123367 [2]
  Submitted by:   Daniel Roethlisberger [1],[2], itetcu@ (me) [3]
  Approved by:    Matt Peterson (former maintainer) [2]
  
  Revision  Changes    Path
  1.3       +111 -71   ports/net-mgmt/collectd/Makefile
  1.1       +27 -0     ports/net-mgmt/collectd/files/collectd.in (new)
  1.1       +20 -0     ports/net-mgmt/collectd/files/patch-src__collectd.h (new)
  1.2       +1 -1      ports/net-mgmt/collectd/pkg-descr
  1.2       +13 -4     ports/net-mgmt/collectd/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 6 dfilter service freebsd_committer freebsd_triage 2008-05-06 11:48:17 UTC
itetcu      2008-05-06 10:48:14 UTC

  FreeBSD ports repository

  Modified files:
    .                    UPDATING 
  Log:
  Add a note about the changes in net-mgmt/collectd
  
  PR:             ports/123367
  Submitted by:   maintainer
  
  Revision  Changes    Path
  1.624     +15 -2     ports/UPDATING
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 7 Ion-Mihai "IOnut" Tetcu freebsd_committer freebsd_triage 2008-05-06 11:48:33 UTC
State Changed
From-To: feedback->closed

Committed with fixes. Thanks