Bug 123591 - [Patch] sysutils/screen: don't make it use /dev/ptmx
Summary: [Patch] sysutils/screen: don't make it use /dev/ptmx
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Cy Schubert
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-05-11 13:50 UTC by Ed Schouten
Modified: 2008-06-10 06:30 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ed Schouten 2008-05-11 13:50:05 UTC 
The new TTY layer I'm developing supports the /dev/ptmx device to remain
compatible with Linux and FreeBSD binaries.

I notice that screen's configure tries to detect /dev/ptmx. If it is
present, it prefers /dev/ptmx over the openpty() routine that's
currently being used.

We shouldn't use it, because screen fails to use the allocated PTY
afterwards.

Fix: 

The following patch makes the configure script check for /nonexistent
instead of /dev/ptmx, which doesn't exist. This effectively disables the
/dev/ptmx code in screen.

--- sysutils/screen/Makefile
+++ sysutils/screen/Makefile
@@ -64,6 +64,7 @@
 
 post-patch:
 	@${RM} ${WRKSRC}/doc/screen.info*
+	@${REINPLACE_CMD} -e 's|/dev/ptmx|/nonexistent|' ${WRKSRC}/configure
 
 post-install:
 	@${MKDIR} ${EXAMPLESDIR}
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2008-05-11 13:50:13 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->cy

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Cy Schubert freebsd_committer freebsd_triage 2008-05-11 15:00:32 UTC 
State Changed
From-To: open->feedback

Emailed originator with concerns.
Comment 3 dfilter service freebsd_committer freebsd_triage 2008-06-10 06:20:14 UTC 
cy          2008-06-10 05:20:09 UTC

  FreeBSD ports repository

  Modified files:
    sysutils/screen      Makefile 
  Log:
  Prefer openpty() over /dev/ptmx.
  
  PR:             123591
  Submitted by:   Ed Schouten <ed@80386.nl>
  
  Revision  Changes    Path
  1.74      +2 -1      ports/sysutils/screen/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 4 Cy Schubert freebsd_committer freebsd_triage 2008-06-10 06:20:39 UTC 
State Changed
From-To: feedback->closed

Comitted. Thanks for the patch.