Add a regression-test target; no functional change. It looks like 24 ports depend on gsl so it's a good idea to add such tests. It doesn't take too long to run.
Maintainer of math/gsl, Please note that PR ports/124764 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/124764 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Sure, it's probably a good idea to make these tests easier to run from ports. Approved, but let's call the new target "check" to correspond with the original sources -- it's easier to type, anyway. --- Edwin Groothuis <edwin@FreeBSD.org> wrote: > Maintainer of math/gsl, > > Please note that PR ports/124764 has just been > submitted. > > If it contains a patch for an upgrade, an > enhancement or a bug fix > you agree on, reply to this email stating that you > approve the patch > and a committer will take care of it. > > The full text of the PR can be found at: > > http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/124764 > > -- > Edwin Groothuis via the GNATS Auto Assign Tool > edwin@FreeBSD.org >
Judging from a number of recent changes to other ports, there seems to be some kind of quality-assurance effort in the ports to provide testing targets to as many ports as possible so that they may be run automatically, under the target "regression-test". If this is the case (and I wish portmgr would tell maintainers about such efforts), then I withdraw my suggestion for altering the patch, and approve the original version. If it's not the case, then just stick with "check". b.
State Changed From-To: feedback->open Maintainer has approved.
miwi 2008-06-21 12:26:14 UTC FreeBSD ports repository Modified files: math/gsl Makefile Log: - Add regression-test target PR: 124764 Submitted by: "Pedro F. Giffuni" <pfgshield-freebsd@yahoo.com> Approved by: maintainer Revision Changes Path 1.41 +3 -0 ports/math/gsl/Makefile _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed Committed. Thanks!