pors/japanese/edict has two problems. 1. It does not work on FreeBSD 7.0 i386. xjdic cannot handle input characters from tty on FreeBSD 7.0. Adding "new.c_cc[VMIN] = 1;" for tcsetattr() solves this problem. 2. Marked as BROKEN for amd64 Patch to xjdxgen.c solves this problem. - indlen = (diclen * 3)/4; + indlen = (diclen * 3*(sizeof(void *)/4))/4; Fix: files/patch-64bit:
Maintainer of japanese/edict, Please note that PR ports/125683 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/125683 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Edwin Groothuis wrote: > Maintainer of japanese/edict, > > Please note that PR ports/125683 has just been submitted. > > If it contains a patch for an upgrade, an enhancement or a bug fix > you agree on, reply to this email stating that you approve the patch > and a committer will take care of it. > > The full text of the PR can be found at: > http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/125683 > It looks like in: files/patch-64bit: --- xjdxgen.c 2008-06-19 17:51:17.000000000 +0900 +++ xjdxgen.c- 2008-06-19 17:50:47.000000000 +0900 @@ -154,7 +154,7 @@ db[diclen] = 10; db[0] = 10; printf("Dictionary size: %ld bytes.\n",dbyte); - indlen = (diclen * 3)/4; + indlen = (diclen * 3*(sizeof(void *)/4))/4; jindex = (unsigned long *)malloc(indlen); if(jindex == NULL) { that indlen = (diclen * 3*(sizeof(long)/4))/4; is better, as the bounds checks in the code read: if (indptr > indlen/sizeof(long)) ... Otherwise looks good. I would be happy if some else took maintainership too...
State Changed From-To: feedback->open Approved, with some changes. Note that maintainer is willing to give up maintainership.
arved 2008-07-27 18:44:06 UTC FreeBSD ports repository Modified files: japanese/edict Makefile japanese/edict/files patch-xjdfrontend.c patch-xjdxgen.c Log: Unbreak on amd64 Set maintainership back to ports PR: 125683 Submitted by: Kazunori_Fujiwara <fujiwara@wide.ad.jp> Approved by: maintainer Revision Changes Path 1.24 +1 -5 ports/japanese/edict/Makefile 1.2 +1 -1 ports/japanese/edict/files/patch-xjdfrontend.c 1.2 +11 -2 ports/japanese/edict/files/patch-xjdxgen.c _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed committed, thanks