Bug 129668 - [maintainer update] Update multimedia/handbrake to 0.9.3
Summary: [maintainer update] Update multimedia/handbrake to 0.9.3
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Beech Rintoul
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-12-16 00:40 UTC by jonathan
Modified: 2008-12-17 23:50 UTC (History)
0 users

See Also:


Attachments
file.diff (34.03 KB, patch)
2008-12-16 00:40 UTC, jonathan
no flags Details | Diff
handbrake_0.9.3.txt (34.11 KB, text/plain)
2008-12-17 00:11 UTC, jonathan
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description jonathan 2008-12-16 00:40:01 UTC
This is an update to the multimedia/handbrake port.  This is unfortunately a very large patch due to a long delay between releases and the number of changes made to the code and supporting libraries.

Currently MASTER_SITES is set to the handbrake project development server which the handbrake developers were rather upset to find out.  The handbrake development team prefers to release handbrake as precompiled binaries and has no infrastructure in place for distributing the dependencies.  After asking in several different areas the general consensus seems to be that FreeBSD should be able to host the distfiles without much trouble and is the recommended approach.  A bzipped tarball of the distfiles can be found at 
http://www.kc8onw.net/~jonathan/temp/handbrake_distfiles.tar.bz2
The port expects the distfiles separated rather than in the tarball, it is just for manual download convenience.

The following patch files have been removed as they are not required to build in the new version and I have encountered no issues with them removed in testing:
patch-configure
patch-contrib-a52dec-configure
patch-contrib-a52dec-libao-audio_out_oss.c
patch-contrib-libsamplerate-configure
patch-contrib-mpeg2dec-configure
patch-contrib-x264-Makefile
patch-contrib-x264-configure
patch-libhb-ports.c

There is also a Linux GUI available for Handbrake but I felt it has been long enough since the release and because the 0.9.2 port did not include a GUI it was better to send this now.

Fix: Patch attached with submission follows:
Comment 1 Beech Rintoul freebsd_committer 2008-12-16 04:49:16 UTC
Responsible Changed
From-To: freebsd-ports-bugs->beech

I'll take it
Comment 2 Beech Rintoul freebsd_committer 2008-12-16 05:01:27 UTC
Port fails on the tinderbox with the following:

Wget contrib/faad2.tar.gz 
LibFaad2 contrib/lib/libfaad.a 
Hmm...  Looks like a unified diff to me...
The text leading up to this was:
--------------------------
|Index: faad2/configure.in
|===================================================================
|--- faad2.orig/configure.in
|+++ faad2/configure.in
--------------------------
Patching file configure.in using Plan A...
Hunk #1 succeeded at 18.
done
aclocal: not found

    cd `dirname contrib/faad2.tar.gz` && CONTRIB=`pwd` &&
     
    cd faad2 && patch -p1 < ../patch-faad2-libtool22.patch &&
    ./bootstrap && ./configure --prefix=$CONTRIB --cache-
file=$CONTRIB/config.cache --disable-shared && gmake && gmake install

...failed LibFaad2 contrib/lib/libfaad.a ...
...failed updating 1 target(s)...
...updated 3 target(s)...
*** Error code 1

Stop in /a/ports/multimedia/handbrake.


Beech
-- 
---------------------------------------------------------------------------------------
Beech Rintoul - FreeBSD Developer - beech@FreeBSD.org
/"\   ASCII Ribbon Campaign  | FreeBSD Since 4.x
\ / - NO HTML/RTF in e-mail   | http://people.freebsd.org/~beech
 X  - NO Word docs in e-mail | Skype: akbeech
/ \  - http://www.FreeBSD.org/releases/7.0R/announce.html
---------------------------------------------------------------------------------------
Comment 3 jonathan 2008-12-17 00:11:15 UTC
Beech Rintoul wrote:
> Port fails on the tinderbox with the following:

I finally set up a tinderbox on my local machine and I have the port
building in my local tinderbox without errors now.  A new patch is attached.

Thanks,
Jonathan
Comment 4 dfilter service freebsd_committer 2008-12-17 23:44:16 UTC
beech       2008-12-17 23:44:02 UTC

  FreeBSD ports repository

  Modified files:
    multimedia/handbrake Makefile distinfo pkg-descr 
    multimedia/handbrake/files patch-contrib-Jamfile 
                               patch-libhb-fifo.c 
  Added files:
    multimedia/handbrake/files patch-contrib-libavformat-udp.c 
  Removed files:
    multimedia/handbrake/files patch-configure 
                               patch-contrib-a52dec-configure 
                               patch-contrib-a52dec-libao-audio_out_oss.c 
                               patch-contrib-libsamplerate-configure 
                               patch-contrib-mpeg2dec-configure 
                               patch-contrib-x264-Makefile 
                               patch-contrib-x264-configure 
                               patch-libhb-ports.c 
  Log:
  - Update to 0.9.3
  
  PR:             ports/129668
  Submitted by:   Jonathan Stewart <jonathan@kc8onw.net> (maintainer)
  
  Revision  Changes    Path
  1.25      +66 -71    ports/multimedia/handbrake/Makefile
  1.6       +39 -33    ports/multimedia/handbrake/distinfo
  1.3       +0 -16     ports/multimedia/handbrake/files/patch-configure (dead)
  1.3       +18 -235   ports/multimedia/handbrake/files/patch-contrib-Jamfile
  1.2       +0 -11     ports/multimedia/handbrake/files/patch-contrib-a52dec-configure (dead)
  1.2       +0 -11     ports/multimedia/handbrake/files/patch-contrib-a52dec-libao-audio_out_oss.c (dead)
  1.1       +10 -0     ports/multimedia/handbrake/files/patch-contrib-libavformat-udp.c (new)
  1.2       +0 -20     ports/multimedia/handbrake/files/patch-contrib-libsamplerate-configure (dead)
  1.2       +0 -11     ports/multimedia/handbrake/files/patch-contrib-mpeg2dec-configure (dead)
  1.2       +0 -20     ports/multimedia/handbrake/files/patch-contrib-x264-Makefile (dead)
  1.2       +0 -11     ports/multimedia/handbrake/files/patch-contrib-x264-configure (dead)
  1.3       +7 -7      ports/multimedia/handbrake/files/patch-libhb-fifo.c
  1.3       +0 -43     ports/multimedia/handbrake/files/patch-libhb-ports.c (dead)
  1.5       +12 -23    ports/multimedia/handbrake/pkg-descr
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 5 Beech Rintoul freebsd_committer 2008-12-17 23:44:19 UTC
State Changed
From-To: open->closed

Committed, Thanks!