Checked on a recent -current with 16 Dec 2008 ports tree. No update for net-mgmt/flow-tools-ng on cvsweb. The flow-rptfmt utility has the path to env hard-coded to /bin/env. FreeBSD has /usr/bin/env instead. flow-rptfmt is the recommended way to create reports from flow-tools data (even though clearly nobody uses it except me. :-) This is probably applicable for net-mgmt/flow-tools/ as well. FreeBSD is the reference platform for my network analysis book, so I'd really like to see this fixed. Fix: See the attached (trivial) patch. Patch attached with submission follows: How-To-Repeat: Install flow-tools-ng. Get some data. Try to use flow-report with a default stat.cfg, i.e.: # flow-cat ft-v05.2008-12-01.12* | flow-report -v TYPE=ip-source/destination-port -v SORT=+flows | less Watch it fail.
Maintainer of net-mgmt/flow-tools-ng, Please note that PR ports/130069 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/130069 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Sorry for late response. How about patching all other python/perl files? Try the attached patch please, however it's really a bit trivial... -- Sphinx of black quartz judge my vow.
Good idea. Seems to work fine. Thanks! On Fri, Jan 02, 2009 at 07:13:24PM +0200, Volodymyr Kostyrko wrote: > Sorry for late response. > > How about patching all other python/perl files? Try the attached patch > please, however it's really a bit trivial... > > -- > Sphinx of black quartz judge my vow. -- Michael W. Lucas mwlucas@BlackHelicopters.org, mwlucas@FreeBSD.org http://www.BlackHelicopters.org/~mwlucas/ "My pessimism extends to the point of even suspecting the sincerity of the pessimists." -- Jean Rostand, French biologist and philosopher
Ok, so I can approve it now. This patch: - fixes invocation of python and perl scripts by correcting path to env executable. -- Sphinx of black quartz judge my vow.
State Changed From-To: feedback->open Maintainer approved.
Responsible Changed From-To: freebsd-ports-bugs->amdmi3 I'll take it.
State Changed From-To: open->closed Committed, with minor changes. Thanks!
amdmi3 2009-01-12 00:32:44 UTC FreeBSD ports repository Modified files: net-mgmt/flow-tools-ng Makefile Log: - Fix invocation of python and perl scripts by correcting path to env executable PR: 130069 Submitted by: Michael W Lucas <mwlucas at blackhelicopters dot org> Approved by: Volodymyr Kostyrko <c dot kworr at gmail dot com> (maintainer) Revision Changes Path 1.2 +3 -0 ports/net-mgmt/flow-tools-ng/Makefile _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"