Bug 131915 - databases/bbdb should probably use emacs22
Summary: databases/bbdb should probably use emacs22
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Yoichi NAKAYAMA
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-20 21:00 UTC by Slaven Rezic
Modified: 2009-04-27 18:00 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Slaven Rezic 2009-02-20 21:00:11 UTC 
	Currently databases/bbdb builds only for emacs21, and there's no
	port for emacs22.

Fix: 

Probably changing the line 

		EMACS_PORT_NAME?=       emacs21

	in the port's Makefile to use emacs22 would help. But I don't
	know what policies exist, whether there should be a
	bbdb-emacs21 and bbdb-emacs22 port etc., so no formal patch
	from me right now.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2009-02-20 21:04:22 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->yoichi

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 yoichi 2009-04-19 14:57:03 UTC 
I think we should respect default value of
EMACS_PORT_NAME in bsd.emacs.mk (== emacs22).
I'd like to apply following change.

Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/databases/bbdb/Makefile,v
retrieving revision 1.7
diff -u -r1.7 Makefile
--- Makefile	19 May 2007 20:01:01 -0000	1.7
+++ Makefile	19 Apr 2009 13:56:26 -0000
@@ -17,7 +17,6 @@
 COMMENT=	Big Brother Database
 
 USE_EMACS=	yes
-EMACS_PORT_NAME?=	emacs21
 
 ALL_TARGET=	bbdb info
 MAKE_ARGS=	MAKE="${MAKE} MAKEINFO=\"makeinfo --no-split\""
Comment 3 dfilter service freebsd_committer freebsd_triage 2009-04-27 17:23:44 UTC 
yoichi      2009-04-27 16:23:29 UTC

  FreeBSD ports repository

  Modified files:
    databases/bbdb       Makefile 
  Log:
  Fix to use emacs22.
  
  PR:             ports/131915
  Submitted by:   Slaven Rezic
  
  Revision  Changes    Path
  1.8       +0 -1      ports/databases/bbdb/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 4 Yoichi NAKAYAMA freebsd_committer freebsd_triage 2009-04-27 17:59:33 UTC 
State Changed
From-To: open->closed

Fix committed, thanks!