Bug 133174 - [msdosfs] [patch] msdosfs must support multibyte international characters in file names
Summary: [msdosfs] [patch] msdosfs must support multibyte international characters in ...
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: Unspecified
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-fs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-29 07:20 UTC by yuri
Modified: 2014-10-06 13:10 UTC (History)
1 user (show)

See Also:

Attachments
file.diff (9.62 KB, patch)
2009-03-29 07:20 UTC, yuri 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description yuri 2009-03-29 07:20:01 UTC 
I am not able to read USB disk with FAT that has Chinese characters in the file names.

This URL has patches that claim to fix this issue for FAT and NTFS:
http://kerneltrap.org/mailarchive/freebsd-fs/2009/2/13/4964134

It's important to support international characters in FAT since lack of
support makes FreeBSD fail to read such disks.

How-To-Repeat: mount_msdosfs -L<your locale> /dev/... /mnt
ls /mnt
<<< see garbage instead of Chinese >>>
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2009-03-30 01:11:27 UTC 
Responsible Changed
From-To: freebsd-bugs->freebsd-fs

Over to maintainer(s).  Apparently there is a patch at the supplied URL.
Comment 2 darkmark 2010-09-30 16:40:52 UTC 
The currently direct link to the url patch.   I hope to try this patch
out soon as this is bothering me moving mp3 files back and forth to my
phone over USB with non-ascii encoded chars in the filenames.

http://btload.googlegroups.com/web/msdosfs.patch?gda=6OJa5z8AAABTKdAk9D4djfQOfSDW4ZV9vKlhdfRkDKO3uYPnaA-gp-toi5oIt3BJMRGeqGBbbj-ccyFKn-rNKC-d1pM_IdV0

or via the google url shortener:

http://goo.gl/CwRn
Comment 3 danfe 2011-05-31 09:35:16 UTC 
I confirm that msdosfs patch (ntfs one is no longer accessible) applies to
my recent 8.2-STABLE and fixes display of Chinese characters with my local
ru_RU.UTF-8 locale.

Discussion on fs@ was followed up Yoshihiro Ota <ota@j.email.ne.jp> [1]
which reported there is someone else working on the same or similar. [2]

I fully agree with Yoshihiro-san in his question:  Does anyone intend to
work on this issue?  We have a patch, we have reports that it works, and
it seems that all is missing is review of msdosfs expert.  And I know we
have those.  ;-)

[1] http://docs.freebsd.org/cgi/mid.cgi?20090216000044.d77fec80.ota
[2] http://docs.freebsd.org/cgi/mid.cgi?courier.44DE0FB1.0001160E
Comment 4 danfe 2011-05-31 18:32:05 UTC 
I've attached a patch (cleaned up some style issues) and fixed typos in
subject/synopsis and audit trail.  Patch author is Xin LI (delphij@).
Comment 5 Kevin Lo freebsd_committer freebsd_triage 2011-11-27 15:45:18 UTC 
State Changed
From-To: open->closed

Fixed. Committed to HEAD(r227650 and r228023).
Comment 6 Yuri Victorovich freebsd_committer freebsd_triage 2012-12-20 21:54:09 UTC 
9.1-STABLE doesn't have this patch.
Need to merge it into 9.1.

Yuri
Comment 7 Eitan Adler freebsd_committer freebsd_triage 2012-12-21 07:44:14 UTC 
State Changed
From-To: closed->patched

committed in HEAD, not STABLE - will this be MFCed?
Comment 8 Yuri Victorovich freebsd_committer freebsd_triage 2013-01-05 00:51:14 UTC 
So what does it take to MFC this?

Yuri
Comment 9 Ed Maste freebsd_committer freebsd_triage 2014-10-06 13:10:37 UTC 
Merged to stable/9 in r230196