Bug 134446 - [PATCH] textproc/htdig: apache@ cleanups
Summary: [PATCH] textproc/htdig: apache@ cleanups
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Philip M. Gollucci
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-05-11 08:00 UTC by Philip M. Gollucci
Modified: 2009-05-29 05:10 UTC (History)
1 user (show)

See Also:

Attachments
htdig-3.2.0.b6_2.patch (1.18 KB, patch)
2009-05-11 08:00 UTC, Philip M. Gollucci 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philip M. Gollucci freebsd_committer freebsd_triage 2009-05-11 08:00:11 UTC 
- Use SF macro 
- USE_APACHE=yes is deprecated
- Remove apache from RUN_DEPENDS
- Style nit

Port maintainer (DougB@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.77
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2009-05-11 08:00:25 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->dougb

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Doug Barton freebsd_committer freebsd_triage 2009-05-26 00:41:20 UTC 
State Changed
From-To: open->feedback


You haven't given any explanation regarding the benefits of 
your proposed changes. Please elaborate. 


Thanks, 

Doug
Comment 3 Philip M. Gollucci freebsd_committer freebsd_triage 2009-05-26 00:47:48 UTC 
State Changed
From-To: feedback->open

feed back received, or will be modulo grey listing
Comment 4 Philip M. Gollucci freebsd_committer freebsd_triage 2009-05-28 22:09:54 UTC 
Responsible Changed
From-To: dougb->pgollucci

Philip M. Gollucci wrote:
> > - Use SF macro
> > You get the full list of mirrors for Source Forge, its also checked
> > for
> > in portlint.
> > 
> > - USE_APACHE=yes is deprecated
> > - Remove apache from RUN_DEPENDS
> > 
> > That seems like justification to me.  See recent CHANGES, UPDATING,
> > and
> > portlint additions.  This will be droppped in bsd.apache.mk in the
> > next
> > run (< 2 months).
> > 
> > In prep of APACHE_PORT=www/apache22 by default,
> > USE_WEBSER=something,
> > and USE_MP=X (mod_perl).  portmgr, and clement@ are in agreement.
> > 
> > - Style nit
> > ${DOCSDIR} vs ${DOCSDIR}/ is actually in the style guide.

Ok, sounds good. You can replace all the master sites (including mine)
with the SF macro.


Thanks for taking an interest,

Doug
http://www.freebsd.org/cgi/query-pr.cgi?pr=134446
Comment 5 dfilter service freebsd_committer freebsd_triage 2009-05-29 05:07:13 UTC 
pgollucci    2009-05-29 04:07:02 UTC

  FreeBSD ports repository

  Modified files:
    textproc/htdig       Makefile 
  Log:
  - Use SF macro
  - USE_APACHE=yes is deprecated
  - Remove apache from RUN_DEPENDS
  - Style nit
  
  PR:             ports/134446
  Approved by:    maintainer
  Submitted by:   me
  
  Revision  Changes    Path
  1.39      +3 -9      ports/textproc/htdig/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 6 Philip M. Gollucci freebsd_committer freebsd_triage 2009-05-29 05:07:20 UTC 
State Changed
From-To: open->closed

Committed. Thanks!