Bug 137712 - graphics/ImageMagick does not build with FreeBSD 7.2
Summary: graphics/ImageMagick does not build with FreeBSD 7.2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Martin Matuska
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-13 05:00 UTC by Stephen Montgomery-Smith
Modified: 2009-08-13 08:20 UTC (History)
0 users

See Also:

Attachments
file.diff (372 bytes, patch)
2009-08-13 05:00 UTC, Stephen Montgomery-Smith 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephen Montgomery-Smith 2009-08-13 05:00:16 UTC 
The port ImageMagick-6.5.4.10 does not build on FreeBSD 7.2, because it uses the function carg, which is only available on FreeBSD 8.

If you look at /usr/src/lib/msun/src/s_carg.c you will see that carg(z) is a drop in replacement for atan2(cimag(z), creal(z)).  Thus the proposed fix may as well be implemented on FreeBSD 8 as well as FreeBSD 7.2.

Fix: Put a patch into files which effects the following patch:
Comment 1 gnats freebsd_committer freebsd_triage 2009-08-13 05:40:19 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->mm

Fix synopsis and assign.
Comment 2 dfilter service freebsd_committer freebsd_triage 2009-08-13 08:19:02 UTC 
mm          2009-08-13 07:18:52 UTC

  FreeBSD ports repository

  Modified files:
    graphics/ImageMagick Makefile 
  Added files:
    graphics/ImageMagick/files patch-magick-fourier.c 
  Log:
  - Fix build on pre-8 systems: replace carg() with atan2()
  - Tinderbox did not discover this
  
  PR:             ports/137712
  Submitted by:   Stephen Montgomery-Smith <stephen@missouri.edu>
  
  Revision  Changes    Path
  1.295     +1 -0      ports/graphics/ImageMagick/Makefile
  1.1       +11 -0     ports/graphics/ImageMagick/files/patch-magick-fourier.c (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Martin Matuska freebsd_committer freebsd_triage 2009-08-13 08:20:51 UTC 
State Changed
From-To: open->closed

Committed. Thanks!