Bug 138272 - graphics/exiv2: add patch from upstream
Summary: graphics/exiv2: add patch from upstream
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-multimedia mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-28 18:50 UTC by Andriy Gapon
Modified: 2009-11-08 09:30 UTC (History)
0 users

See Also:


Attachments
patch-tiffcomposite.cpp (676 bytes, text/plain)
2009-08-28 18:50 UTC, Andriy Gapon
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andriy Gapon 2009-08-28 18:50:03 UTC
I am getting the following crash when I try to import a certain image with digikam:

#6  0x000000080687a55c in thr_kill () from /lib/libc.so.7
#7  0x0000000806901233 in abort () from /lib/libc.so.7
#8  0x00000008068ea119 in __assert () from /lib/libc.so.7
#9  0x000000080253af0a in Exiv2::Internal::TiffMnEntry::doCount ()
   from /usr/local/lib/libexiv2.so.7
#10 0x000000080253b355 in Exiv2::Internal::TiffDirectory::writeDirEntry ()
   from /usr/local/lib/libexiv2.so.7
#11 0x000000080253e4ff in Exiv2::Internal::TiffDirectory::doWrite ()
   from /usr/local/lib/libexiv2.so.7
#12 0x000000080253c16b in Exiv2::Internal::TiffSubIfd::doWriteData ()
   from /usr/local/lib/libexiv2.so.7
#13 0x000000080253b4bb in Exiv2::Internal::TiffDirectory::doWriteData ()
   from /usr/local/lib/libexiv2.so.7
#14 0x000000080253e6a0 in Exiv2::Internal::TiffDirectory::doWrite ()
   from /usr/local/lib/libexiv2.so.7
#15 0x0000000802542d9e in Exiv2::Internal::TiffParserWorker::encode ()
   from /usr/local/lib/libexiv2.so.7
#16 0x0000000802542ef1 in Exiv2::TiffParser::encode ()
   from /usr/local/lib/libexiv2.so.7
#17 0x00000008024e4382 in Exiv2::ExifParser::encode ()
   from /usr/local/lib/libexiv2.so.7
#18 0x0000000802326b9e in KExiv2Iface::KExiv2::getExif ()
   from /usr/local/lib/libkexiv2.so.5
#19 0x0000000800a78e17 in Digikam::ImagePropertiesSideBarCamGui::itemChanged
    () from /usr/local/lib/libdigikam.so.0

The image was taken with a Nokia phone camera and contains some non-empty
Exif.Photo.MakerNote (type Ascii, size 1088).

I believe that this issue was fixed upstream:
http://dev.exiv2.org/repositories/revision/exiv2/1743
http://dev.exiv2.org/issues/show/615
I applied this change in my local ports tree and it seems to fix the problem.

I also see that Debian folks have included this change into their package of
exiv2. Could we please do the same?

Fix: Please add the following patch obtained from upstream to files/.
How-To-Repeat: Try to import into digikam a suitable image (photo) with non-empty Exif.Photo.MakerNote
that has any type other than 'undefined'.
Comment 1 Edwin Groothuis freebsd_committer 2009-08-28 18:50:19 UTC
Responsible Changed
From-To: freebsd-ports-bugs->freebsd-multimedia

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer 2009-11-08 09:29:05 UTC
arved       2009-11-08 09:28:51 UTC

  FreeBSD ports repository

  Modified files:
    graphics/exiv2       Makefile 
  Added files:
    graphics/exiv2/files patch-src-tiffcomposite.cpp 
  Log:
  Fix a digikam-crash with a patch from upstream
  
  PR:             138272
  Submitted by:   Andriy Gapon <avg@icyb.net.ua>
  
  Revision  Changes    Path
  1.27      +1 -0      ports/graphics/exiv2/Makefile
  1.1       +20 -0     ports/graphics/exiv2/files/patch-src-tiffcomposite.cpp (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Tilman Keskinoz freebsd_committer 2009-11-08 09:29:09 UTC
State Changed
From-To: open->closed

committed, thanks