The attached shar file (with the extension .txt because the browser MIME type problems) contains a patch for the port Makefile to have it install gearman 0.9 and and patch to the configure script to allow it to correctly detect the presence of libmemcached. As the configure script will detect the SQLite 3 and PostgresSQL client libraries automatically and there is no way to turn off detection, the port now also checks for these libraries and adds them as dependencies if present, and does the same with libmemcached. Fix: Patch attached with submission follows:
Maintainer of devel/gearmand, Please note that PR ports/138614 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/138614 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Sorry, I forgot the pkg-plist updates. I only realised after I'd submitted the PR. I also noticed that a number of the man pages could be excluded based on what database client libraries were present, and added knobs to allow the database client libraries to be required if not already installed. The attached shar file contains the necessary patches. -- Keith Gaughan - kmgaughan@eircom.net - http://talideon.com/ - CF9F6473 Odd things, animals. Dogs look up to you. Cats look down to you. Only pigs see you as an equal. -- Winston Churchill
Hello all, Please use this new attachment as patch. This one uses OPTIONS to let users to select. On Mon, Sep 07, 2009 at 05:30:10PM +0000, Edwin Groothuis wrote: > Maintainer of devel/gearmand, > > Please note that PR ports/138614 has just been submitted. > > If it contains a patch for an upgrade, an enhancement or a bug fix > you agree on, reply to this email stating that you approve the patch > and a committer will take care of it. > > The full text of the PR can be found at: > http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/138614 > > -- > Edwin Groothuis via the GNATS Auto Assign Tool > edwin@FreeBSD.org -- * Gea-Suan Lin (public key: Using https://keyserver.pgp.com/ to search) * If you cannot convince them, confuse them. -- Harry S Truman
Sorry forget to attach. On Wed, Sep 09, 2009 at 11:52:54AM +0800, Gea-Suan Lin wrote: > Hello all, > > Please use this new attachment as patch. This one uses OPTIONS to let > users to select. > > On Mon, Sep 07, 2009 at 05:30:10PM +0000, Edwin Groothuis wrote: > > Maintainer of devel/gearmand, > > > > Please note that PR ports/138614 has just been submitted. > > > > If it contains a patch for an upgrade, an enhancement or a bug fix > > you agree on, reply to this email stating that you approve the patch > > and a committer will take care of it. > > > > The full text of the PR can be found at: > > http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/138614 > > > > -- > > Edwin Groothuis via the GNATS Auto Assign Tool > > edwin@FreeBSD.org > > -- > * Gea-Suan Lin (public key: Using https://keyserver.pgp.com/ to search) > * If you cannot convince them, confuse them. -- Harry S Truman -- * Gea-Suan Lin (public key: Using https://keyserver.pgp.com/ to search) * If you cannot convince them, confuse them. -- Harry S Truman
The maintainer's patch is over all better than mine, but has a problem my original patch did not have - in the maintainer's patch, libmemcached support is broken. To fix this, please include the patch-configure file from my original patch, and add in this line from my original patch to the Makefile: CONFIGURE_ARGS+=3D --without-memcached The libmemcached detection code in the configure script has a small bug in it that prevents it from correctly detecting the presence of the library. My patch-configure fixes that. However, configure also attempts to run tests if libmemcached is detected that depend on memcached itself; the above line disables those tests. I'd appreciate if the maintainer or committer could apply these changes before the update is committed to ports. K. --=20 Keith Gaughan - k@stereochro.me - http://stereochro.me/ They accused us of suppressing freedom of expression. This was a lie and we could not let them publish it. -- Nelba Blandon, Nicaraguan Interior Ministry Director of Censorship
State Changed From-To: feedback->closed New port added, with minor changes. Thanks!
miwi 2009-09-19 12:00:16 UTC FreeBSD ports repository Modified files: devel/gearmand Makefile distinfo pkg-plist Log: - Update to 0.9 - Add support for SQLite and PostgresSQL PR: 138614 Submitted by: Keith Gaughan <k@stereochro.me> (based on) Approved by: maintainer Feature safe: yes Revision Changes Path 1.8 +36 -2 ports/devel/gearmand/Makefile 1.7 +3 -3 ports/devel/gearmand/distinfo 1.6 +3 -1 ports/devel/gearmand/pkg-plist _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"