Bug 141733 - [patch] audio/akode-plugins-xiph: Makefile fixes for portlint
Summary: [patch] audio/akode-plugins-xiph: Makefile fixes for portlint
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: kde
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-18 02:50 UTC by Glen Barber
Modified: 2009-12-18 11:10 UTC (History)
0 users

See Also:


Attachments
file.diff (1.83 KB, patch)
2009-12-18 02:50 UTC, Glen Barber
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Glen Barber 2009-12-18 02:50:03 UTC
portlint finds FATAL errors in the Makefile for this port, such as:
 - use a tab (not space) after a variable name
 - extra item placed in the PORTNAME section
 - extra item placed in the MAINTAINER section

Additionally, portlint warns PLIST_FLAGS should be used when pkg-plist contains 6 or less entries.

Fix: Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer 2009-12-18 02:50:28 UTC
Responsible Changed
From-To: freebsd-ports-bugs->kde

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer 2009-12-18 11:08:39 UTC
fluffy      2009-12-18 11:08:30 UTC

  FreeBSD ports repository

  Modified files:
    audio/akode-plugins-xiph Makefile 
  Removed files:
    audio/akode-plugins-xiph pkg-plist 
  Log:
  - Portlint, tweak plist
  
  PR:             141733
  Submitted by:   glen.j.barber AT gmail.com
  Approved by:    miwi (mentor)
  
  Revision  Changes    Path
  1.26      +13 -9     ports/audio/akode-plugins-xiph/Makefile
  1.4       +0 -3      ports/audio/akode-plugins-xiph/pkg-plist (dead)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Dima Panov freebsd_committer 2009-12-18 11:10:06 UTC
State Changed
From-To: open->closed

Committed. Thanks!