Bug 143254 - [patch] groff(1) build in base system does not honor PAGE setting in /etc/make.conf
Summary: [patch] groff(1) build in base system does not honor PAGE setting in /etc/mak...
Status: Closed Overcome By Events
Alias: None
Product: Base System
Classification: Unclassified
Component: gnu (show other bugs)
Version: 8.0-RELEASE
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-26 11:40 UTC by Armin Gruner
Modified: 2017-07-24 18:00 UTC (History)
1 user (show)

See Also:

Attachments
file.diff (480 bytes, patch)
2010-01-26 11:40 UTC, Armin Gruner 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Armin Gruner 2010-01-26 11:40:06 UTC 
When building the base system, the PAGE setting in /etc/make.conf is not honored. Thus, the installed devps backend of groff will always emit a ``letter'' papersize postscript document.

Fix: Changing PAGE=letter in /usr/src/usr.bin/groff/Makefile.inc to
PAGE?=letter allows to override the make variable. 

See attached patch.

$ grep PAGE /usr/src/gnu/usr.bin/groff/Makefile.inc
PAGE?=letter

$ make -C /usr/src/gnu/usr.bin/groff/font/devps

$ grep papersize /usr/obj/usr/src/gnu/usr.bin/groff/font/devps/DESC
papersize a4


Patch attached with submission follows:
How-To-Repeat: Goto /usr/src/gnu/usr.bin/groff/font/devps, do a "make" and 
inspect the generated DESC:

$ grep PAGE /etc/make.conf
PAGE=A4

$ grep PAGE /usr/src/gnu/usr.bin/groff/Makefile.inc
PAGE=letter

$ make -C /usr/src/gnu/usr.bin/groff/font/devps

$ grep papersize /usr/obj/usr/src/gnu/usr.bin/groff/font/devps/DESC
papersize letter
Comment 1 Enji Cooper freebsd_committer freebsd_triage 2017-07-24 18:00:09 UTC 
groff is no longer present on ^/head.